From: Chris Mason <chris.mason@oracle.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: Miao Xie <miaox@cn.fujitsu.com>,
Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [3.0-rc1] delayed insertion allocation failing...
Date: Mon, 30 May 2011 15:11:21 -0400 [thread overview]
Message-ID: <1306782464-sup-7709@shiny> (raw)
In-Reply-To: <BANLkTinv0GDkGy6mhC2DVrt6wW7ZGQPPrQ@mail.gmail.com>
Excerpts from Daniel J Blueman's message of 2011-05-30 10:24:08 -0400:
> Hi Miao,
>
> When booting 3.0-rc1 with an existing BTRFS filesystem with a normal
> desktop use pattern, we see btrfs_batch_insert_item() sometimes
> attempt an overly-large kmalloc (>= order 11) [1], which is
> subsequently failed.
Wow, that's a big allocation. Not really sure how this manages to
compile with a warning.
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 01e2950..790262d 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -678,6 +678,7 @@ static int btrfs_batch_insert_items(struct btrfs_trans_handle *trans,
INIT_LIST_HEAD(&head);
next = item;
+ nitems = 0;
/*
* count the number of the continuous items that we can insert in batch
prev parent reply other threads:[~2011-05-30 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 14:24 [3.0-rc1] delayed insertion allocation failing Daniel J Blueman
2011-05-30 19:11 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306782464-sup-7709@shiny \
--to=chris.mason@oracle.com \
--cc=daniel.blueman@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).