From: Chris Mason <chris.mason@oracle.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] another reader/writer lock for btrfs metadata
Date: Tue, 26 Jul 2011 18:00:21 -0400 [thread overview]
Message-ID: <1311717520-sup-188@shiny> (raw)
In-Reply-To: <1311643645-sup-5605@shiny>
Excerpts from Chris Mason's message of 2011-07-25 21:28:30 -0400:
> Excerpts from Chris Mason's message of 2011-07-25 14:34:49 -0400:
> > Hi everyone,
> >
> > I've updated the integration-test branch to use this code instead. It
> > is a shiny new reader/writer lock built around rw spinlocks. I've
> > removed all the adaptive spinning and started trusting the hints btrfs
> > already has about when blocks should block or spin.
>
> I tested with lockdep and looks like I've got a bug in btrfs_next_leaf's
> lockdep handling. So, please don't run this code with
> CONFIG_DEBUG_LOCK_ALLOC turned on. The bug is only in lockdep mode, so
> we're fine with it off.
>
> I'll fix it up in the morning.
Ok, I've rebased the btrfs integration-test branch to include fixes for
the lockdep problems. I've also adapted Tejun's lockdep class patch to
the new code. With this setup I'm not getting lockdep warnings, but I'm
always looking for more bug reports.
-chris
next prev parent reply other threads:[~2011-07-26 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 18:34 [PATCH] another reader/writer lock for btrfs metadata Chris Mason
2011-07-26 1:28 ` Chris Mason
2011-07-26 22:00 ` Chris Mason [this message]
2011-07-27 8:13 ` Arne Jansen
2011-07-27 12:42 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311717520-sup-188@shiny \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).