From: Ilya Dryomov <idryomov@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Chris Mason <chris.mason@oracle.com>,
Hugo Mills <hugo@carfax.org.uk>,
idryomov@gmail.com
Subject: [PATCH 21/21] Btrfs: add restripe progress reporting
Date: Tue, 23 Aug 2011 23:02:02 +0300 [thread overview]
Message-ID: <1314129722-31601-22-git-send-email-idryomov@gmail.com> (raw)
In-Reply-To: <1314129722-31601-1-git-send-email-idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---
fs/btrfs/ioctl.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
fs/btrfs/ioctl.h | 2 ++
fs/btrfs/volumes.c | 40 ++++++++++++++++++++++++++++++++++------
fs/btrfs/volumes.h | 3 +++
4 files changed, 84 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 4f29149..a342544 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2966,6 +2966,49 @@ static long btrfs_ioctl_restripe_ctl(struct btrfs_root *root,
return -EINVAL;
}
+static long btrfs_ioctl_restripe_progress(struct btrfs_root *root,
+ void __user *arg)
+{
+ struct btrfs_fs_info *fs_info = root->fs_info;
+ struct btrfs_ioctl_restripe_args *rargs;
+ struct restripe_control *rctl;
+ int ret = 0;
+
+ if (!capable(CAP_SYS_ADMIN))
+ return -EPERM;
+
+ mutex_lock(&fs_info->restripe_mutex);
+ if (!(rctl = fs_info->restripe_ctl)) {
+ ret = -ENOTCONN;
+ goto out;
+ }
+
+ rargs = kzalloc(sizeof(*rargs), GFP_NOFS);
+ if (!rargs) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ rargs->flags = rctl->flags;
+ rargs->state = fs_info->restripe_state;
+
+ memcpy(&rargs->data, &rctl->data, sizeof(rargs->data));
+ memcpy(&rargs->sys, &rctl->sys, sizeof(rargs->sys));
+ memcpy(&rargs->meta, &rctl->meta, sizeof(rargs->meta));
+
+ spin_lock(&fs_info->restripe_lock);
+ memcpy(&rargs->stat, &rctl->stat, sizeof(rargs->stat));
+ spin_unlock(&fs_info->restripe_lock);
+
+ if (copy_to_user(arg, rargs, sizeof(*rargs)))
+ ret = -EFAULT;
+
+ kfree(rargs);
+out:
+ mutex_unlock(&fs_info->restripe_mutex);
+ return ret;
+}
+
long btrfs_ioctl(struct file *file, unsigned int
cmd, unsigned long arg)
{
@@ -3042,6 +3085,8 @@ long btrfs_ioctl(struct file *file, unsigned int
return btrfs_ioctl_restripe(root, argp);
case BTRFS_IOC_RESTRIPE_CTL:
return btrfs_ioctl_restripe_ctl(root, arg);
+ case BTRFS_IOC_RESTRIPE_PROGRESS:
+ return btrfs_ioctl_restripe_progress(root, argp);
}
return -ENOTTY;
diff --git a/fs/btrfs/ioctl.h b/fs/btrfs/ioctl.h
index 365d06c..2154816 100644
--- a/fs/btrfs/ioctl.h
+++ b/fs/btrfs/ioctl.h
@@ -290,4 +290,6 @@ struct btrfs_ioctl_space_args {
#define BTRFS_IOC_RESTRIPE _IOW(BTRFS_IOCTL_MAGIC, 32, \
struct btrfs_ioctl_restripe_args)
#define BTRFS_IOC_RESTRIPE_CTL _IOW(BTRFS_IOCTL_MAGIC, 33, int)
+#define BTRFS_IOC_RESTRIPE_PROGRESS _IOR(BTRFS_IOCTL_MAGIC, 34, \
+ struct btrfs_ioctl_restripe_args)
#endif
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index ead4996..9a248b9 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2187,8 +2187,10 @@ static void set_restripe_control(struct restripe_control *rctl, int update)
spin_lock(&fs_info->restripe_lock);
fs_info->restripe_ctl = rctl;
- if (update)
+ if (update) {
update_restripe_args(rctl);
+ memset(&rctl->stat, 0, sizeof(rctl->stat));
+ }
spin_unlock(&fs_info->restripe_lock);
}
@@ -2419,6 +2421,7 @@ static int __btrfs_restripe(struct btrfs_root *dev_root)
int slot;
int ret;
int enospc_errors = 0;
+ bool counting_only = true;
/* step one make some room on all the devices */
devices = &dev_root->fs_info->fs_devices->devices;
@@ -2451,12 +2454,14 @@ static int __btrfs_restripe(struct btrfs_root *dev_root)
goto error;
}
+again:
key.objectid = BTRFS_FIRST_CHUNK_TREE_OBJECTID;
key.offset = (u64)-1;
key.type = BTRFS_CHUNK_ITEM_KEY;
while (1) {
struct btrfs_fs_info *fs_info = dev_root->fs_info;
+ struct restripe_control *rctl = fs_info->restripe_ctl;
if (test_bit(RESTRIPE_CANCEL_REQ, &fs_info->restripe_state) ||
test_bit(RESTRIPE_PAUSE_REQ, &fs_info->restripe_state)) {
@@ -2493,25 +2498,48 @@ static int __btrfs_restripe(struct btrfs_root *dev_root)
chunk = btrfs_item_ptr(leaf, slot, struct btrfs_chunk);
- if (!should_restripe_chunk(chunk_root, leaf, chunk,
- found_key.offset)) {
- btrfs_release_path(path);
- goto loop;
+ if (!counting_only) {
+ spin_lock(&fs_info->restripe_lock);
+ rctl->stat.considered++;
+ spin_unlock(&fs_info->restripe_lock);
}
+ ret = should_restripe_chunk(chunk_root, leaf, chunk,
+ found_key.offset);
btrfs_release_path(path);
+ if (!ret)
+ goto loop;
+
+ if (counting_only) {
+ spin_lock(&fs_info->restripe_lock);
+ rctl->stat.expected++;
+ spin_unlock(&fs_info->restripe_lock);
+ goto loop;
+ }
+
ret = btrfs_relocate_chunk(chunk_root,
chunk_root->root_key.objectid,
found_key.objectid,
found_key.offset);
if (ret && ret != -ENOSPC)
goto error;
- if (ret == -ENOSPC)
+ if (ret == -ENOSPC) {
enospc_errors++;
+ } else {
+ spin_lock(&fs_info->restripe_lock);
+ rctl->stat.completed++;
+ spin_unlock(&fs_info->restripe_lock);
+ }
loop:
key.offset = found_key.offset - 1;
}
+ if (counting_only) {
+ btrfs_release_path(path);
+ counting_only = false;
+ goto again;
+ }
+
error:
btrfs_free_path(path);
if (enospc_errors) {
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index 20da71f..5ca3b3b 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -207,6 +207,7 @@ struct map_lookup {
#define RESTRIPE_PAUSE_REQ 2
struct btrfs_restripe_args;
+struct btrfs_restripe_progress;
struct restripe_control {
struct btrfs_fs_info *fs_info;
u64 flags;
@@ -214,6 +215,8 @@ struct restripe_control {
struct btrfs_restripe_args data;
struct btrfs_restripe_args sys;
struct btrfs_restripe_args meta;
+
+ struct btrfs_restripe_progress stat;
};
int btrfs_account_dev_extents_size(struct btrfs_device *device, u64 start,
--
1.7.5.4
next prev parent reply other threads:[~2011-08-23 20:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 20:01 [PATCH 00/21] [RFC] Btrfs: restriper Ilya Dryomov
2011-08-23 20:01 ` [PATCH 01/21] Btrfs: get rid of *_alloc_profile fields Ilya Dryomov
2011-09-27 12:51 ` David Sterba
2011-08-23 20:01 ` [PATCH 02/21] Btrfs: introduce masks for chunk type and profile Ilya Dryomov
2011-08-23 20:01 ` [PATCH 03/21] Btrfs: add BTRFS_AVAIL_ALLOC_BIT_SINGLE bit Ilya Dryomov
2011-11-01 7:56 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 04/21] Btrfs: make avail_*_alloc_bits fields dynamic Ilya Dryomov
2011-08-23 20:01 ` [PATCH 05/21] Btrfs: add basic restriper infrastructure Ilya Dryomov
2011-11-01 10:08 ` Arne Jansen
2011-11-01 11:07 ` David Sterba
2011-11-01 11:08 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 06/21] Btrfs: implement online profile changing Ilya Dryomov
2011-08-23 20:01 ` [PATCH 07/21] Btrfs: add basic infrastructure for selective balancing Ilya Dryomov
2011-09-27 13:02 ` David Sterba
2011-09-27 17:28 ` Ilya Dryomov
2011-08-23 20:01 ` [PATCH 08/21] Btrfs: soft profile changing mode (aka soft convert) Ilya Dryomov
2011-08-23 20:01 ` [PATCH 09/21] Btrfs: profiles filter Ilya Dryomov
2011-08-23 20:01 ` [PATCH 10/21] Btrfs: usage filter Ilya Dryomov
2011-09-27 13:22 ` David Sterba
2011-11-01 10:18 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 11/21] Btrfs: devid filter Ilya Dryomov
2011-08-23 20:01 ` [PATCH 12/21] Btrfs: devid subset filter Ilya Dryomov
2011-08-23 20:01 ` [PATCH 13/21] Btrfs: virtual address space " Ilya Dryomov
2011-08-23 20:01 ` [PATCH 14/21] Btrfs: save restripe parameters to disk Ilya Dryomov
2011-09-27 13:43 ` David Sterba
2011-11-01 10:29 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 15/21] Btrfs: recover restripe on mount Ilya Dryomov
2011-11-01 10:57 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 16/21] Btrfs: allow for cancelling restriper Ilya Dryomov
2011-08-23 20:01 ` [PATCH 17/21] Btrfs: allow for pausing restriper Ilya Dryomov
2011-11-01 11:46 ` Arne Jansen
2011-08-23 20:01 ` [PATCH 18/21] Btrfs: allow for resuming restriper after it was paused Ilya Dryomov
2011-08-23 20:02 ` [PATCH 19/21] Btrfs: add skip_restripe mount option Ilya Dryomov
2011-08-23 20:02 ` [PATCH 20/21] Btrfs: get rid of btrfs_balance() function Ilya Dryomov
2011-08-23 20:02 ` Ilya Dryomov [this message]
2011-09-27 12:47 ` [PATCH 00/21] [RFC] Btrfs: restriper David Sterba
2011-11-14 23:59 ` Phillip Susi
2011-11-15 9:22 ` Ilya Dryomov
2011-11-15 14:33 ` Phillip Susi
2011-11-15 15:06 ` Ilya Dryomov
2011-11-17 3:13 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314129722-31601-22-git-send-email-idryomov@gmail.com \
--to=idryomov@gmail.com \
--cc=chris.mason@oracle.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).