linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Asdo <asdo@shiftmail.org>
Cc: Chester <somethingsome2000@gmail.com>,
	Jeff Putney <jeffrey.putney@gmail.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Honest timeline for btrfsck
Date: Mon, 10 Oct 2011 08:59:02 -0400	[thread overview]
Message-ID: <1318251388-sup-3431@shiny> (raw)
In-Reply-To: <4E8F4EA9.4090108@shiftmail.org>

Excerpts from Asdo's message of 2011-10-07 15:10:33 -0400:
> On 10/07/11 04:25, Chester wrote:
> > The problem with this is that people naturally look for a fsck tool
> > when something bad goes wrong. Something as important as a fsck
> > utility shouldn't be released (unofficially or officially) half baked.
> > It can irreparably destroy a filesystem which could've otherwise been
> > repaired with a fully functional fsck.
> >
> > I think Chris is trying to prevent that from happening.
> 
> What I would like to know instead, is WHY we need an btrfsck when ZFS 
> does not. Zfs also has this kind of problems especially on power 
> failures, but you can always mount by rolling back to a previous 
> uberblock, showing an earlier view of the filesystem, which would be 
> consistent.
> 
> It wasn't always like this with ZFS, but this "feature" has been added 
> after ther numerous requests of users who lost their complete 
> filesystems after a power failure or similar events. And there was no 
> zfsck (there still isn't, and it's apparently not needed).

One of my patches here adds a circular ring of past roots for a similar
feature.  The problem is that blocks get reused after a commit, so we
have to either slow that down (making enospc even more complex) or we'd
have to just use the past super and hope.

It gets even worse because things past supers aren't always enough.  The
drive can just plain corrupt an important block, or write-back cache
problems can make corruptions that last much longer than the last 5 or
10 commits.  Bad things do happen to good data, so you just plain need a
real fsck.

-chris

  parent reply	other threads:[~2011-10-10 12:59 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03  6:57 Honest timeline for btrfsck Erik Jensen
2011-08-03  9:09 ` Jan Schmidt
2011-08-03 20:53 ` Chris Mason
2011-08-15 14:22   ` Francesco Riosa
2011-08-17 15:19   ` Dave
2011-08-18  1:09   ` Yalonda Gishtaka
2011-08-18 20:50     ` Chris Mason
2011-08-18 21:22       ` Hugo Mills
2011-08-26  0:39         ` Yalonda Gishtaka
2011-08-21 13:58       ` Maciej Marcin Piechotka
2011-08-25 15:06       ` Michael Cronenworth
2011-09-01 19:14         ` Michael Cronenworth
2011-09-01 20:20           ` Hugo Mills
2011-09-01 20:24             ` Michael Cronenworth
2011-09-01 20:34               ` Hugo Mills
2011-09-10 10:09                 ` Martin Steigerwald
2011-09-13 18:01                   ` Jeff Putney
2011-10-05  6:16                     ` Chris Mason
2011-10-05 13:59                       ` Jeff Putney
2011-10-05 14:58                         ` Chris Mason
2011-10-06 15:31                           ` Jeff Putney
2011-10-06 20:30                             ` Andi Kleen
2011-10-06 20:33                               ` Jeff Mahoney
2011-10-06 20:56                               ` Francesco Riosa
2011-10-07 14:50                                 ` Josef Bacik
2011-10-07 15:22                                   ` Dave
2011-10-11 21:21                                   ` Francesco Riosa
2011-10-12 13:53                                     ` Josef Bacik
2011-10-13 12:57                                       ` Francesco Riosa
2011-10-13 13:02                                         ` Josef Bacik
2011-10-06 20:52                             ` Randy Barlow
2011-10-06 23:20                             ` Yalonda Gishtaka
2011-10-06 23:29                               ` Chris Samuel
2011-10-07  4:30                               ` Roman Mamedov
2011-10-07  2:25                             ` Chester
2011-10-07 19:10                               ` Asdo
2011-10-07 19:29                                 ` cwillu
2011-10-07 20:19                                 ` Diego Calleja
2011-10-08 21:13                                   ` Asdo
2011-10-09  1:19                                     ` Fajar A. Nugraha
2011-10-07 20:50                                 ` Helmut Hullen
2011-10-10 12:59                                 ` Chris Mason [this message]
2011-10-07  2:50                             ` Chris Mason
2011-10-07  4:45                               ` Jeff Mahoney
2011-10-07 13:40                               ` Jeff Putney
2011-10-07 14:48                                 ` Josef Bacik
2011-10-07 15:58                                   ` Jeff Putney
2011-10-07 16:08                                     ` Josef Bacik
2011-10-07 17:07                                       ` Jeff Putney
2011-10-07 18:23                                         ` cwillu
2011-10-07 21:16                                           ` Jeff Putney
2011-10-10 12:55                                     ` Chris Mason
2011-10-13 11:28                                   ` Chris Samuel
2011-10-13 11:37                                     ` Hugo Mills
2011-10-07 15:39                               ` Mike
2011-10-07 17:27                                 ` Gour-Gadadhara Dasa
2011-10-12 14:41                                   ` Martin Steigerwald
2011-10-12 18:57                                     ` Jeff Putney
2011-10-12 19:53                                       ` Martin Steigerwald
2011-10-12 22:47                                         ` Jeff Putney
2011-10-13  5:56                                           ` Jeff Mahoney
2011-10-13 15:51                                             ` Jeff Putney
2011-10-17 10:49                                               ` Chris Samuel
2011-10-31 10:53                       ` David Summers
2011-11-30 10:19                         ` Clemens Eisserer
2011-12-02 20:05                           ` Jeff Putney
2012-01-06 23:03                       ` Danny Piccirillo
2011-09-09 23:01           ` Yalonda Gishtaka
2011-09-23 13:51       ` Erik Jensen
2011-09-27 14:42       ` Jeff Putney
2011-09-27 18:00         ` Clemens Eisserer
2011-10-04 21:20           ` Jeff Putney
2012-01-17 15:07       ` David Summers
2012-01-18  1:13         ` Chris Mason
2012-03-28  6:15           ` Danny Piccirillo
2012-03-28  9:36             ` Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318251388-sup-3431@shiny \
    --to=chris.mason@oracle.com \
    --cc=asdo@shiftmail.org \
    --cc=jeffrey.putney@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=somethingsome2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).