Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Keith Mannthey <kmannth@us.ibm.com>
To: linux-btrfs@vger.kernel.org
Subject: [RFC][PATCH] Sector Size check during Mount
Date: Tue, 29 Nov 2011 17:44:12 -0800	[thread overview]
Message-ID: <1322617452.10304.15.camel@keith-laptop> (raw)

Gracefully fail when trying to mount a BTRFS file system that has a
sectorsize smaller than PAGE_SIZE.  

On PPC it is possible to build a FS while using a 4k PAGE_SIZE kernel
then boot into a 64K PAGE_SIZE kernel.  Presently open_ctree fails in an
endless loop and hangs the machine in this situation. 

My debugging has show this Sector size < Page size to be a non trivial
situation and a graceful exit from the situation would be nice for the
time being. 


Signed-off-by:  Keith Mannthey <kmannth@us.ibm.com>

---

diff -urN a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
--- a/fs/btrfs/disk-io.c	2011-10-09 21:53:11.000000000 -0500
+++ b/fs/btrfs/disk-io.c	2011-11-29 17:33:15.000000000 -0600
@@ -1916,6 +1916,12 @@
 		goto fail_sb_buffer;
 	}
 
+	if (sectorsize < PAGE_SIZE) {
+		printk(KERN_WARNING "btrfs: Incompatible sector size "
+		       "found on %s\n", sb->s_id);
+		goto fail_sb_buffer;
+	}
+
 	mutex_lock(&fs_info->chunk_mutex);
 	ret = btrfs_read_sys_array(tree_root);
 	mutex_unlock(&fs_info->chunk_mutex);



             reply	other threads:[~2011-11-30  1:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  1:44 Keith Mannthey [this message]
2011-11-30 15:06 ` [RFC][PATCH] Sector Size check during Mount Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322617452.10304.15.camel@keith-laptop \
    --to=kmannth@us.ibm.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox