From: Bobby Powers <bobbypowers@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Bobby Powers <bobbypowers@gmail.com>,
Ilya Dryomov <idryomov@gmail.com>,
Chris Mason <chris.mason@oracle.com>,
Andi Kleen <ak@linux.intel.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Btrfs: remove BUG_ON from get_restripe_target
Date: Wed, 4 Apr 2012 16:19:34 -0400 [thread overview]
Message-ID: <1333570774-26462-1-git-send-email-bobbypowers@gmail.com> (raw)
spin_is_locked always returns 0 on non-SMP systems, which causes btrfs
to fail the mount. There is documentation pending as to why checking
for spin_is_locked is a bad idea:
https://lkml.org/lkml/2012/3/27/413
As this was the only location in fs/btrfs/extent-tree.c that did
lock-correctness checking in a BUG_ON, simply remove it.
Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
CC: Ilya Dryomov <idryomov@gmail.com>
CC: Chris Mason <chris.mason@oracle.com>
CC: Andi Kleen <ak@linux.intel.com>
CC: linux-btrfs@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
fs/btrfs/extent-tree.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index a844204..c98b073 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -3158,9 +3158,6 @@ static u64 get_restripe_target(struct btrfs_fs_info *fs_info, u64 flags)
struct btrfs_balance_control *bctl = fs_info->balance_ctl;
u64 target = 0;
- BUG_ON(!mutex_is_locked(&fs_info->volume_mutex) &&
- !spin_is_locked(&fs_info->balance_lock));
-
if (!bctl)
return 0;
--
1.7.10.rc3.3.g19a6c
next reply other threads:[~2012-04-04 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 20:19 Bobby Powers [this message]
2012-04-05 0:46 ` [PATCH] Btrfs: remove BUG_ON from get_restripe_target Jeff Mahoney
2012-04-05 1:19 ` Bobby Powers
2012-04-05 1:48 ` Bobby Powers
2012-04-05 2:04 ` [PATCH v2] Btrfs, lockdep: get_restripe_target: use lockdep in BUG_ON Bobby Powers
2012-04-05 16:23 ` Bobby Powers
2012-04-05 16:51 ` Ilya Dryomov
2012-04-06 17:20 ` Mitch Harder
2012-04-06 20:05 ` Ilya Dryomov
2012-04-07 1:06 ` Bobby Powers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333570774-26462-1-git-send-email-bobbypowers@gmail.com \
--to=bobbypowers@gmail.com \
--cc=ak@linux.intel.com \
--cc=chris.mason@oracle.com \
--cc=idryomov@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).