linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Block <ablock84@googlemail.com>
To: linux-btrfs@vger.kernel.org
Cc: Alexander Block <ablock84@googlemail.com>
Subject: [PATCH 0/5] introduce btrfs filesystem property command
Date: Sun, 24 Jun 2012 23:20:03 +0200	[thread overview]
Message-ID: <1340572808-30281-1-git-send-email-ablock84@googlemail.com> (raw)

This patchset introduces the btrfs filesystem property command. It is the
result of a discussion we had on IRC. I tried to make the properties
interface as generic and extensible as possible. Comments are welcome.

Currently the command looks like this:
btrfs fi prop /path/to/object [name[=value]]

Some people may prefer other forms. For example I got suggestions for
these forms:
btrfs set/get /path/to/object [name [value]]
btrfs prop /pach/to/object [name[=value]] (and also without the =)

I'm open to more suggestions and a discussion on this. I'm definitely
for removing the fi[lesystem] prefix but I'm neutral to the other 
suggestions made so far.

For now, I've implemented three properties:
1. read-only. Usable on subvolumes to toggle the read-only flags.
2. label. I looked through btrfs to find good examples of things that
   could be moved to the new properties interface and the filesystem
   label looked like a good one. There are for sure more, but that is
   something for later (and maybe for someone else). I would suggest 
   to move everthing that makes sense over to the props interface and 
   mark the old interfaces as deprecated. Comments on this are welcome.

Alex.

Alexander Block (5):
  Btrfs-progs: add BTRFS_IOC_SUBVOL_GET/SETFLAGS to ioctl.h
  Btrfs-progs: move skip_prefix and prefixcmp to utils.c
  Btrfs-progs: let get_label return the label instead of of printing it
  Btrfs-progs: make filesystem_cmd_group non const
  Btrfs-progs: introduce btrfs filesystem property command

 Makefile          |    3 +-
 btrfs.c           |   19 +--
 btrfslabel.c      |   13 +-
 btrfslabel.h      |    4 +-
 cmds-filesystem.c |  115 +++++++++++++-
 commands.h        |    9 +-
 help.c            |    2 +
 ioctl.h           |    2 +
 props.c           |  460 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 props.h           |   45 ++++++
 utils.c           |   15 ++
 utils.h           |    3 +
 12 files changed, 659 insertions(+), 31 deletions(-)
 create mode 100644 props.c
 create mode 100644 props.h

-- 
1.7.10


             reply	other threads:[~2012-06-24 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 21:20 Alexander Block [this message]
2012-06-24 21:20 ` [PATCH 1/5] Btrfs-progs: add BTRFS_IOC_SUBVOL_GET/SETFLAGS to ioctl.h Alexander Block
2012-06-24 21:20 ` [PATCH 2/5] Btrfs-progs: move skip_prefix and prefixcmp to utils.c Alexander Block
2012-06-24 21:20 ` [PATCH 3/5] Btrfs-progs: let get_label return the label instead of of printing it Alexander Block
2012-06-24 21:20 ` [PATCH 4/5] Btrfs-progs: make filesystem_cmd_group non const Alexander Block
2012-06-24 22:14   ` Alexander Block
2012-06-24 21:20 ` [PATCH 5/5] Btrfs-progs: introduce btrfs filesystem property command Alexander Block
2012-06-27  2:25 ` [PATCH 0/5] " Liu Bo
2012-06-27 11:08   ` Alexander Block
2012-06-28 13:08 ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340572808-30281-1-git-send-email-ablock84@googlemail.com \
    --to=ablock84@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).