From: Pierre Carrier <pierre@spotify.com>
To: linux-btrfs@vger.kernel.org
Cc: Pierre Carrier <pierre@spotify.com>
Subject: [PATCH 2/2] utils.c: offer to limit divisions in pretty_sizes
Date: Mon, 9 Jul 2012 17:30:21 +0000 [thread overview]
Message-ID: <1341855021-14551-1-git-send-email-pierre@spotify.com> (raw)
In-Reply-To: <1341853347-11788-3-git-send-email-pierre@spotify.com>
Dirty hack to allow inspection of sizes in lower units.
Useful to know the minimum size a partition shoud be resized to
after a 'btrfs filesystem resize'.
Label: 'home' uuid: 10453c4c-1c5b-4df5-b4a5-43a7f377430a
Total devices 1 FS bytes used 42.80GB
devid 1 size 62.16GB used 62.16GB path /dev/sda5
Label: 'home' uuid: 10453c4c-1c5b-4df5-b4a5-43a7f377430a
Total devices 1 FS bytes used 44884524.00KB
devid 1 size 65182236.00KB used 65182208.00KB path /dev/sda5
Signed-off-by: Pierre Carrier <pierre@spotify.com>
diff --git a/utils.c b/utils.c
index 937e763..3f0b7e7 100644
--- a/utils.c
+++ b/utils.c
@@ -1096,13 +1096,18 @@ static char *size_strs[] = { "", "KB", "MB", "GB", "TB",
char *pretty_sizes(u64 size)
{
int num_divs = 0;
+ int max_divs = INT_MAX;
int pretty_len = 16;
u64 last_size = size;
u64 fract_size = size;
float fraction;
char *pretty;
+ char *max_divs_s;
- while(size > 0) {
+ if (max_divs_s = getenv("MAX_DIVS"))
+ max_divs = atoi(max_divs_s);
+
+ while(size > 0 && num_divs <= max_divs) {
fract_size = last_size;
last_size = size;
size /= 1024;
@@ -1117,7 +1122,6 @@ char *pretty_sizes(u64 size)
if (num_divs > ARRAY_SIZE(size_strs))
return NULL;
-
pretty = malloc(pretty_len);
if (!pretty)
return NULL;
--
1.7.11.1
next prev parent reply other threads:[~2012-07-09 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 17:02 [PATCH 0/2] Support for small units in display Pierre Carrier
2012-07-09 17:02 ` [PATCH 1/2] utils.c: fix sizes in B & malloc in pretty_sizes Pierre Carrier
2012-07-09 17:29 ` Pierre Carrier
2012-07-17 12:43 ` David Sterba
2012-07-09 17:02 ` [PATCH 2/2] utils.c: offer to limit divisions " Pierre Carrier
2012-07-09 17:30 ` Pierre Carrier [this message]
2012-07-17 12:58 ` David Sterba
2012-07-09 17:27 ` [PATCH 0/2] Support for small units in display Pierre Carrier
2012-07-17 12:34 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341855021-14551-1-git-send-email-pierre@spotify.com \
--to=pierre@spotify.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).