* [PATCH v2 1/2] Btrfs: Check INCOMPAT flags on remount with lzo compression
@ 2012-07-20 19:12 Mitch Harder
2012-07-20 19:12 ` [PATCH v2 2/2] Btrfs: Use common function to check lzo INCOMPAT on defrag Mitch Harder
0 siblings, 1 reply; 2+ messages in thread
From: Mitch Harder @ 2012-07-20 19:12 UTC (permalink / raw)
To: linux-btrfs; +Cc: Mitch Harder
In support of the recently added capability to remount with lzo
compression, check the compression INCOMPAT flags when remounting
with lzo compression, and set the flags if necessary.
Signed-off-by: Mitch Harder <mitch.harder@sabayonlinux.org>
---
v1-v2:
- Remove extraneous formatting change.
fs/btrfs/ctree.h | 1 +
fs/btrfs/super.c | 18 ++++++++++++++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index a0ee2f8..8bee032 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -3094,6 +3094,7 @@ ssize_t btrfs_listxattr(struct dentry *dentry, char *buffer, size_t size);
/* super.c */
int btrfs_parse_options(struct btrfs_root *root, char *options);
+void btrfs_chk_lzo_incompat(struct btrfs_root *root);
int btrfs_sync_fs(struct super_block *sb, int wait);
void btrfs_printk(struct btrfs_fs_info *fs_info, const char *fmt, ...);
void __btrfs_std_error(struct btrfs_fs_info *fs_info, const char *function,
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 26da344..f3a5967 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -401,6 +401,7 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
compress_type = "lzo";
info->compress_type = BTRFS_COMPRESS_LZO;
btrfs_set_opt(info->mount_opt, COMPRESS);
+ btrfs_chk_lzo_incompat(root);
} else if (strncmp(args[0].from, "no", 2) == 0) {
compress_type = "no";
info->compress_type = BTRFS_COMPRESS_NONE;
@@ -587,6 +588,23 @@ out:
}
/*
+ * Check the INCOMPAT features in the super block, and set the
+ * LZO INCOMPAT flag if it has not been set.
+ */
+void btrfs_chk_lzo_incompat(struct btrfs_root *root)
+{
+ struct btrfs_super_block *disk_super;
+ u64 features;
+
+ disk_super = root->fs_info->super_copy;
+ features = btrfs_super_incompat_flags(disk_super);
+ if (!(features & BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO)) {
+ features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO;
+ btrfs_set_super_incompat_flags(disk_super, features);
+ }
+}
+
+/*
* Parse mount options that are required early in the mount process.
*
* All other options will be parsed on much later in the mount process and
--
1.7.8.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] Btrfs: Use common function to check lzo INCOMPAT on defrag.
2012-07-20 19:12 [PATCH v2 1/2] Btrfs: Check INCOMPAT flags on remount with lzo compression Mitch Harder
@ 2012-07-20 19:12 ` Mitch Harder
0 siblings, 0 replies; 2+ messages in thread
From: Mitch Harder @ 2012-07-20 19:12 UTC (permalink / raw)
To: linux-btrfs; +Cc: Mitch Harder
When defragmenting with explicit lzo compression, simplify
the check for lzo INCOMPAT by using the new common function
introduced to support remounting with lzo compression.
Signed-off-by: Mitch Harder <mitch.harder@sabayonlinux.org>
---
fs/btrfs/ioctl.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 17facea..d5fd69e 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -1042,11 +1042,9 @@ int btrfs_defrag_file(struct inode *inode, struct file *file,
u64 newer_than, unsigned long max_to_defrag)
{
struct btrfs_root *root = BTRFS_I(inode)->root;
- struct btrfs_super_block *disk_super;
struct file_ra_state *ra = NULL;
unsigned long last_index;
u64 isize = i_size_read(inode);
- u64 features;
u64 last_len = 0;
u64 skip = 0;
u64 defrag_end = 0;
@@ -1233,11 +1231,8 @@ int btrfs_defrag_file(struct inode *inode, struct file *file,
mutex_unlock(&inode->i_mutex);
}
- disk_super = root->fs_info->super_copy;
- features = btrfs_super_incompat_flags(disk_super);
if (range->compress_type == BTRFS_COMPRESS_LZO) {
- features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO;
- btrfs_set_super_incompat_flags(disk_super, features);
+ btrfs_chk_lzo_incompat(root);
}
ret = defrag_count;
--
1.7.8.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-20 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 19:12 [PATCH v2 1/2] Btrfs: Check INCOMPAT flags on remount with lzo compression Mitch Harder
2012-07-20 19:12 ` [PATCH v2 2/2] Btrfs: Use common function to check lzo INCOMPAT on defrag Mitch Harder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).