From: Robin Dong <robin.k.dong@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Robin Dong <sanbai@taobao.com>
Subject: [PATCH v2 2/2] btrfs-progs: limit the min value of total_bytes
Date: Fri, 28 Sep 2012 11:02:40 +0800 [thread overview]
Message-ID: <1348801360-1851-2-git-send-email-robin.k.dong@gmail.com> (raw)
In-Reply-To: <1348801360-1851-1-git-send-email-robin.k.dong@gmail.com>
From: Robin Dong <sanbai@taobao.com>
Using mkfs.btrfs like:
mkfs.btrfs -b 1048576 /dev/sda
will report error:
mkfs.btrfs: volumes.c:796: btrfs_alloc_chunk: Assertion `!(ret)' failed.
Aborted
because the length of dev_extent is 4MB.
But if we use mkfs.btrfs with 8MB total bytes, the newly mounted btrfs filesystem
would not contain even one empty file. So 12MB will be good min-value for block_count.
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
mkfs.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/mkfs.c b/mkfs.c
index 8420482..496faa8 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1345,7 +1345,11 @@ int main(int ac, char **av)
&dev_block_count, &mixed, nodiscard);
if (block_count == 0)
block_count = dev_block_count;
- else if (block_count > dev_block_count) {
+ else if (block_count < 3 * BTRFS_MKFS_SYSTEM_GROUP_SIZE) {
+ fprintf(stderr, "Illegal total number of bytes %u\n",
+ block_count);
+ exit(1);
+ } else if (block_count > dev_block_count) {
fprintf(stderr, "%s is smaller than requested size\n", file);
exit(1);
}
--
1.7.3.2
next prev parent reply other threads:[~2012-09-28 3:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 3:02 [PATCH v2 1/2] btrfs-progs: limit the max value of leafsize and nodesize Robin Dong
2012-09-28 3:02 ` Robin Dong [this message]
2012-09-30 23:05 ` [PATCH v2 2/2] btrfs-progs: limit the min value of total_bytes David Sterba
2012-10-08 7:10 ` Robin Dong
2012-09-30 22:46 ` [PATCH v2 1/2] btrfs-progs: limit the max value of leafsize and nodesize David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348801360-1851-2-git-send-email-robin.k.dong@gmail.com \
--to=robin.k.dong@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).