linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.cz>
Subject: [PATCH 2/4] btrfs-progs: add option g to show generation, do not show it by default
Date: Tue,  9 Oct 2012 18:27:53 +0200	[thread overview]
Message-ID: <1349800075-4888-2-git-send-email-dsterba@suse.cz> (raw)
In-Reply-To: <1349800075-4888-1-git-send-email-dsterba@suse.cz>

The generation was not printed so far, and adding 'g' will pair the 'G'
filter.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 btrfs-list.c     |    2 +-
 cmds-subvolume.c |    8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/btrfs-list.c b/btrfs-list.c
index e5f0f96..3821064 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -105,7 +105,7 @@ struct {
 	{
 		.name		= "gen",
 		.column_name	= "Gen",
-		.need_print	= 1,
+		.need_print	= 0,
 	},
 	{
 		.name		= "cgen",
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 61be38a..a2dece6 100644
--- a/cmds-subvolume.c
+++ b/cmds-subvolume.c
@@ -277,7 +277,7 @@ out:
  * - lowercase for enabling specific items in the output
  */
 static const char * const cmd_subvol_list_usage[] = {
-	"btrfs subvolume list [-apurts] [-G [+|-]value] [-C [+|-]value] "
+	"btrfs subvolume list [-agpurts] [-G [+|-]value] [-C [+|-]value] "
 	"[--sort=gen,ogen,rootid,path] <path>",
 	"List subvolumes (and snapshots)",
 	"",
@@ -285,6 +285,7 @@ static const char * const cmd_subvol_list_usage[] = {
 	"-a           print all the subvolumes in the filesystem.",
 	"-u           print the uuid of subvolumes (and snapshots)",
 	"-t           print the result as a table",
+	"-g           print the generation of the subvolume",
 	"-s           list snapshots only in the filesystem",
 	"-r           list readonly subvolumes (including snapshots)",
 	"-G [+|-]value",
@@ -323,7 +324,7 @@ static int cmd_subvol_list(int argc, char **argv)
 	optind = 1;
 	while(1) {
 		c = getopt_long(argc, argv,
-				    "apsurG:C:t", long_options, NULL);
+				    "agpsurG:C:t", long_options, NULL);
 		if (c < 0)
 			break;
 
@@ -334,6 +335,9 @@ static int cmd_subvol_list(int argc, char **argv)
 		case 'a':
 			is_list_all = 1;
 			break;
+		case 'g':
+			btrfs_list_setup_print_column(BTRFS_LIST_GENERATION);
+			break;
 		case 't':
 			is_tab_result = 1;
 			break;
-- 
1.7.6.233.gd79bc


  reply	other threads:[~2012-10-09 16:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 16:27 [PATCH 1/4] btrfs-progs: upcase filter options David Sterba
2012-10-09 16:27 ` David Sterba [this message]
2012-10-09 16:27 ` [PATCH 3/4] btrfs-progs: add option c to show ogeneration David Sterba
2012-10-09 16:27 ` [PATCH 4/4] btrfs-progs: update man pages of subvol list David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349800075-4888-2-git-send-email-dsterba@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).