linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org
Cc: ablock84@googlemail.com, sensille@gmx.net
Subject: [PATCH v2 0/2] Btrfs-progs: urgent fixes for btrfs send
Date: Tue,  6 Nov 2012 21:47:06 +0100	[thread overview]
Message-ID: <1352234828-9446-1-git-send-email-list.btrfs@jan-o-sch.net> (raw)

After sending v1 some days ago, some onlist and offlist discussion has
brought us to the following conclusions:

	- we should fix it as soon as possible
	- we should stick to the -p option (parent)
	- we should rename the -i option (because it actually means
	  "clone source")

This is what v2 of this patch set is doing, besides fixing one and a
half bugs along the way: We turn -i into -c, emitting a fatal warning
should anybody use -i. As argued in the v1 cover letter, we should
really do this change now in order to avoid a lot of confused users that
"btrfs send -i" is doing things differently in a subtle way from what
"zfs send -i" is doing. We're better off coming up with our own
terminology, thus offering -p and -c options (both can be used to ask
for an incremental send stream, see the usage changes in patch 1),
without providing a "send -i" option at all.

Jan Schmidt (2):
  Btrfs-progs: correcting misnamed parameter options for btrfs send
  Btrfs-progs: bugfix for subvolume parent determination in btrfs send

 cmds-send.c  |   74 +++++++++++++++++++++++++++++++++-------------------------
 send-utils.c |    4 +-
 2 files changed, 44 insertions(+), 34 deletions(-)


             reply	other threads:[~2012-11-06 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 20:47 Jan Schmidt [this message]
2012-11-06 20:47 ` [PATCH v2 1/2] Btrfs-progs: correcting misnamed parameter options for btrfs send Jan Schmidt
2012-11-06 20:47 ` [PATCH v2 2/2] Btrfs-progs: bugfix for subvolume parent determination in " Jan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352234828-9446-1-git-send-email-list.btrfs@jan-o-sch.net \
    --to=list.btrfs@jan-o-sch.net \
    --cc=ablock84@googlemail.com \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sensille@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).