From: Liu Bo <bo.li.liu@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/2] Btrfs: add leak debug for extent map
Date: Tue, 8 Jan 2013 22:49:20 +0800 [thread overview]
Message-ID: <1357656561-24604-1-git-send-email-bo.li.liu@oracle.com> (raw)
This is for detecting extent map leak.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
fs/btrfs/extent_map.c | 31 +++++++++++++++++++++++++++++++
fs/btrfs/extent_map.h | 1 +
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index f169d6b..c025a7a 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -9,6 +9,13 @@
static struct kmem_cache *extent_map_cache;
+static LIST_HEAD(emaps);
+
+#define LEAK_DEBUG 0
+#if LEAK_DEBUG
+static DEFINE_SPINLOCK(map_leak_lock);
+#endif
+
int __init extent_map_init(void)
{
extent_map_cache = kmem_cache_create("btrfs_extent_map",
@@ -21,6 +28,16 @@ int __init extent_map_init(void)
void extent_map_exit(void)
{
+ struct extent_map *em;
+
+ while (!list_empty(&emaps)) {
+ em = list_entry(emaps.next, struct extent_map, leak_list);
+ printk(KERN_ERR "btrfs ext map leak: start %llu len %llu block %llu flags %llu refs %d in tree %d compress %d\n",
+ em->start, em->len, em->block_start, em->flags, atomic_read(&em->refs), em->in_tree, em->compress_type);
+ list_del(&em->leak_list);
+ kmem_cache_free(extent_map_cache, em);
+ }
+
if (extent_map_cache)
kmem_cache_destroy(extent_map_cache);
}
@@ -48,6 +65,9 @@ void extent_map_tree_init(struct extent_map_tree *tree)
*/
struct extent_map *alloc_extent_map(void)
{
+#if LEAK_DEBUG
+ unsigned long flags;
+#endif
struct extent_map *em;
em = kmem_cache_zalloc(extent_map_cache, GFP_NOFS);
if (!em)
@@ -58,6 +78,11 @@ struct extent_map *alloc_extent_map(void)
em->generation = 0;
atomic_set(&em->refs, 1);
INIT_LIST_HEAD(&em->list);
+#if LEAK_DEBUG
+ spin_lock_irqsave(&map_leak_lock, flags);
+ list_add(&em->leak_list, &emaps);
+ spin_unlock_irqrestore(&map_leak_lock, flags);
+#endif
return em;
}
@@ -74,6 +99,12 @@ void free_extent_map(struct extent_map *em)
return;
WARN_ON(atomic_read(&em->refs) == 0);
if (atomic_dec_and_test(&em->refs)) {
+#if LEAK_DEBUG
+ unsigned long flags;
+ spin_lock_irqsave(&map_leak_lock, flags);
+ list_del(&em->leak_list);
+ spin_unlock_irqrestore(&map_leak_lock, flags);
+#endif
WARN_ON(em->in_tree);
WARN_ON(!list_empty(&em->list));
kmem_cache_free(extent_map_cache, em);
diff --git a/fs/btrfs/extent_map.h b/fs/btrfs/extent_map.h
index 922943c..d07a841 100644
--- a/fs/btrfs/extent_map.h
+++ b/fs/btrfs/extent_map.h
@@ -35,6 +35,7 @@ struct extent_map {
unsigned int in_tree;
unsigned int compress_type;
struct list_head list;
+ struct list_head leak_list;
};
struct extent_map_tree {
--
1.7.7.6
next reply other threads:[~2013-01-08 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 14:49 Liu Bo [this message]
2013-01-08 14:49 ` [PATCH 2/2] Btrfs: fix memory leak on extent map after fsync Liu Bo
2013-01-24 16:44 ` Josef Bacik
2013-01-25 1:38 ` Liu Bo
2013-01-25 2:23 ` Liu Bo
2013-01-24 16:52 ` Josef Bacik
2013-01-08 20:07 ` [PATCH 1/2] Btrfs: add leak debug for extent map Zach Brown
2013-01-10 2:05 ` Liu Bo
2013-01-10 11:54 ` David Sterba
2013-01-10 13:11 ` Liu Bo
2013-01-11 15:31 ` David Sterba
2013-01-10 17:06 ` Zach Brown
2013-01-11 8:45 ` Liu Bo
2013-01-11 20:54 ` Zach Brown
2013-01-13 12:18 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357656561-24604-1-git-send-email-bo.li.liu@oracle.com \
--to=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).