From: Eric Sandeen <sandeen@redhat.com>
To: linux-btrfs@vger.kernel.org
Cc: Eric Sandeen <sandeen@redhat.com>
Subject: [PATCH 02/11] btrfs: list_entry can't return NULL
Date: Wed, 30 Jan 2013 18:54:53 -0600 [thread overview]
Message-ID: <1359593702-53056-3-git-send-email-sandeen@redhat.com> (raw)
In-Reply-To: <1359593702-53056-1-git-send-email-sandeen@redhat.com>
No need to test the result, we can't get a
null pointer from list_entry()
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
fs/btrfs/disk-io.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index a8f652d..d89da40 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3823,8 +3823,6 @@ int btrfs_cleanup_transaction(struct btrfs_root *root)
while (!list_empty(&list)) {
t = list_entry(list.next, struct btrfs_transaction, list);
- if (!t)
- break;
btrfs_destroy_ordered_operations(root);
--
1.7.1
next prev parent reply other threads:[~2013-01-31 0:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 0:54 [PATCH 0/11] btrfs: misc fixes and cleanups Eric Sandeen
2013-01-31 0:15 ` Zach Brown
2013-01-31 0:54 ` [PATCH 01/11] btrfs: remove unused fd in btrfs_ioctl_send() Eric Sandeen
2013-01-31 0:54 ` Eric Sandeen [this message]
2013-01-31 0:54 ` [PATCH 03/11] btrfs: remove unused fs_info from btrfs_decode_error() Eric Sandeen
2013-01-31 0:54 ` [PATCH 04/11] btrfs: handle null fs_info in btrfs_panic() Eric Sandeen
2013-01-31 0:54 ` [PATCH 05/11] btrfs: annotate intentional switch case fallthroughs Eric Sandeen
2013-01-31 0:54 ` [PATCH 06/11] btrfs: add missing break in btrfs_print_leaf() Eric Sandeen
2013-01-31 0:54 ` [PATCH 07/11] btrfs: fix varargs in __btrfs_std_error Eric Sandeen
2013-01-31 0:54 ` [PATCH 08/11] btrfs: remove unused "item" in btrfs_insert_delayed_item() Eric Sandeen
2013-01-31 0:55 ` [PATCH 09/11] btrfs: remove unnecessary DEFINE_WAIT() declarations Eric Sandeen
2013-01-31 0:55 ` [PATCH 10/11] btrfs: ensure we don't overrun devices_info[] in __btrfs_alloc_chunk Eric Sandeen
2013-01-31 0:55 ` [PATCH 11/11] btrfs: don't try to notify udev about missing devices Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359593702-53056-3-git-send-email-sandeen@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).