[PATCH] Btrfs-progs print more informative error when we fail to open a device

[PATCH] Btrfs-progs print more informative error when we fail to open a device

[Gene Czarcinski]

I believe that this patch may have been lost in the noise and I felt
it made a very small but meaningful change so I shuffled some
test around and made sure it applied to integration-20120201

This patch simply prints more informative message when
we fail to open a device.

Eric Sandeen (1):
  Btrfs-progs print more informative error when we fail to open a device
 utils.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1

[PATCH] Btrfs-progs print more informative error when we fail to open a device

[Gene Czarcinski]

From: Eric Sandeen <sandeen@redhat.com>

print more informative error when we fail to open a device

If open() fails, we should let the user know why it failed.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Gene Czarcinski <gene@czarc.net>
---
 utils.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/utils.c b/utils.c
index d92f317..b560a49 100644
--- a/utils.c
+++ b/utils.c
@@ -1212,7 +1212,8 @@ scan_again:
 
 		fd = open(fullpath, O_RDONLY);
 		if (fd < 0) {
-			fprintf(stderr, "failed to read %s\n", fullpath);
+			fprintf(stderr, "failed to open %s: %s\n",
+				fullpath, strerror(errno));
 			continue;
 		}
 		ret = btrfs_scan_one_device(fd, fullpath, &tmp_devices,
-- 
1.8.1

Re: [PATCH] Btrfs-progs print more informative error when we fail to open a device

[David Sterba]

On Mon, Feb 04, 2013 at 10:57:57AM -0500, Gene Czarcinski wrote:
> From: Eric Sandeen <sandeen@redhat.com>
> 
> print more informative error when we fail to open a device
> 
> If open() fails, we should let the user know why it failed.

Thanks, added to next integration queue.