From: Wang Shilong <wangshilong1991@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: wangshilong1991@gmail.com
Subject: [PATCH 2/2] Btrfs-progs: output the error reason when qgroup_show fails
Date: Wed, 27 Feb 2013 19:04:18 +0800 [thread overview]
Message-ID: <1361963058-1966-1-git-send-email-wangshilong1991@gmail.com> (raw)
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
The original code forgot to output the reason why the commands failed,
fix it.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
cmds-qgroup.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/cmds-qgroup.c b/cmds-qgroup.c
index 79888c8..275f00f 100644
--- a/cmds-qgroup.c
+++ b/cmds-qgroup.c
@@ -298,6 +298,7 @@ static int cmd_qgroup_show(int argc, char **argv)
{
int ret = 0;
int fd;
+ int e;
char *path = argv[1];
if (check_argc_exact(argc, 2))
@@ -310,9 +311,11 @@ static int cmd_qgroup_show(int argc, char **argv)
}
ret = list_qgroups(fd);
+ e = errno;
close(fd);
if (ret < 0) {
- fprintf(stderr, "ERROR: can't list qgroups\n");
+ fprintf(stderr, "ERROR: can't list qgroups: %s\n",
+ strerror(e));
return 30;
}
--
1.7.7.6
reply other threads:[~2013-02-27 11:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361963058-1966-1-git-send-email-wangshilong1991@gmail.com \
--to=wangshilong1991@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).