* [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 @ 2013-03-04 1:37 zwu.kernel 2013-04-20 23:13 ` Frank A. Kingswood 0 siblings, 1 reply; 4+ messages in thread From: zwu.kernel @ 2013-03-04 1:37 UTC (permalink / raw) To: linux-btrfs; +Cc: dsterba, Zhi Yong Wu From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> Since raid5/6 support was introduced, we should update mkfs.btrfs help info. Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> --- mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs.c b/mkfs.c index 5ece186..f9f26a5 100644 --- a/mkfs.c +++ b/mkfs.c @@ -326,7 +326,7 @@ static void print_usage(void) fprintf(stderr, "options:\n"); fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n"); fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n"); - fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n"); + fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n"); fprintf(stderr, "\t -l --leafsize size of btree leaves\n"); fprintf(stderr, "\t -L --label set a label\n"); fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n"); -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 2013-03-04 1:37 [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 zwu.kernel @ 2013-04-20 23:13 ` Frank A. Kingswood 2013-04-20 23:48 ` Eric Sandeen 0 siblings, 1 reply; 4+ messages in thread From: Frank A. Kingswood @ 2013-04-20 23:13 UTC (permalink / raw) To: linux-btrfs On 04/03/13 01:37, zwu.kernel@gmail.com wrote: > From: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> > > Since raid5/6 support was introduced, we should update mkfs.btrfs help info. > > Signed-off-by: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> > --- > mkfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs.c b/mkfs.c > index 5ece186..f9f26a5 100644 > --- a/mkfs.c > +++ b/mkfs.c > @@ -326,7 +326,7 @@ static void print_usage(void) > fprintf(stderr, "options:\n"); > fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n"); > fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n"); > - fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n"); > + fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n"); > fprintf(stderr, "\t -l --leafsize size of btree leaves\n"); > fprintf(stderr, "\t -L --label set a label\n"); > fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n"); Nitpick: that line of output is now longer than 80. Perhaps instead of "\t " have a few spaces at the start of each line. Frank ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 2013-04-20 23:13 ` Frank A. Kingswood @ 2013-04-20 23:48 ` Eric Sandeen [not found] ` <CAEH94Lg2b9uYk=+cf_KXKnFYnMxPBM_rKGJairX14TtvGHD=ww@mail.gmail.com> 0 siblings, 1 reply; 4+ messages in thread From: Eric Sandeen @ 2013-04-20 23:48 UTC (permalink / raw) To: Frank A. Kingswood; +Cc: linux-btrfs On 4/20/13 4:13 PM, Frank A. Kingswood wrote: > On 04/03/13 01:37, zwu.kernel@gmail.com wrote: >> From: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> >> >> Since raid5/6 support was introduced, we should update mkfs.btrfs help info. >> >> Signed-off-by: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> >> --- >> mkfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mkfs.c b/mkfs.c >> index 5ece186..f9f26a5 100644 >> --- a/mkfs.c >> +++ b/mkfs.c >> @@ -326,7 +326,7 @@ static void print_usage(void) >> fprintf(stderr, "options:\n"); >> fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n"); >> fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n"); >> - fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n"); >> + fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n"); >> fprintf(stderr, "\t -l --leafsize size of btree leaves\n"); >> fprintf(stderr, "\t -L --label set a label\n"); >> fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n"); > > Nitpick: that line of output is now longer than 80. Perhaps instead of "\t " have a few spaces at the start of each line. or maybe: + fprintf(stderr, "\t -d --data data profile: [raid0|raid1|raid5|raid6|raid10|dup|single]\n"); I think that fits... > Frank > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAEH94Lg2b9uYk=+cf_KXKnFYnMxPBM_rKGJairX14TtvGHD=ww@mail.gmail.com>]
* Re: [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 [not found] ` <CAEH94Lg2b9uYk=+cf_KXKnFYnMxPBM_rKGJairX14TtvGHD=ww@mail.gmail.com> @ 2013-04-21 9:36 ` Zhi Yong Wu 0 siblings, 0 replies; 4+ messages in thread From: Zhi Yong Wu @ 2013-04-21 9:36 UTC (permalink / raw) To: Eric Sandeen; +Cc: Frank A. Kingswood, linux-btrfs I found this patch had been merged into David's unstable btrfs-progs git, but not into its master git, so don't know the reason. If it need me to send v2 based on your comments, please let me know, thanks. On Sun, Apr 21, 2013 at 5:33 PM, Zhi Yong Wu <zwu.kernel@gmail.com> wrote: > I found this patch had been merged into David's unstable btrfs-progs git, > but not into its master git, so don't know the reason. If it need me to send > v2 based on your comments, please let me know, thanks. > > > > On Sun, Apr 21, 2013 at 7:48 AM, Eric Sandeen <sandeen@redhat.com> wrote: >> >> On 4/20/13 4:13 PM, Frank A. Kingswood wrote: >> > On 04/03/13 01:37, zwu.kernel@gmail.com wrote: >> >> From: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> >> >> >> >> Since raid5/6 support was introduced, we should update mkfs.btrfs >> >> help info. >> >> >> >> Signed-off-by: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com> >> >> --- >> >> mkfs.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/mkfs.c b/mkfs.c >> >> index 5ece186..f9f26a5 100644 >> >> --- a/mkfs.c >> >> +++ b/mkfs.c >> >> @@ -326,7 +326,7 @@ static void print_usage(void) >> >> fprintf(stderr, "options:\n"); >> >> fprintf(stderr, "\t -A --alloc-start the offset to start the >> >> FS\n"); >> >> fprintf(stderr, "\t -b --byte-count total number of bytes in the >> >> FS\n"); >> >> - fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, >> >> dup or single\n"); >> >> + fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, >> >> raid6, raid10, dup or single\n"); >> >> fprintf(stderr, "\t -l --leafsize size of btree leaves\n"); >> >> fprintf(stderr, "\t -L --label set a label\n"); >> >> fprintf(stderr, "\t -m --metadata metadata profile, values like >> >> data profile\n"); >> > >> > Nitpick: that line of output is now longer than 80. Perhaps instead of >> > "\t " have a few spaces at the start of each line. >> >> or maybe: >> >> + fprintf(stderr, "\t -d --data data profile: >> [raid0|raid1|raid5|raid6|raid10|dup|single]\n"); >> >> I think that fits... >> >> > Frank >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" >> > in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Regards, > > Zhi Yong Wu -- Regards, Zhi Yong Wu ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-21 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 1:37 [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6 zwu.kernel
2013-04-20 23:13 ` Frank A. Kingswood
2013-04-20 23:48 ` Eric Sandeen
[not found] ` <CAEH94Lg2b9uYk=+cf_KXKnFYnMxPBM_rKGJairX14TtvGHD=ww@mail.gmail.com>
2013-04-21 9:36 ` Zhi Yong Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).