linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Btrfs-progs: fix reference check for roots in btrfsck
@ 2013-06-05 14:12 Josef Bacik
  0 siblings, 0 replies; only message in thread
From: Josef Bacik @ 2013-06-05 14:12 UTC (permalink / raw)
  To: linux-btrfs

I noticed that I was getting these errors on a bigger file system with more
snapshots that had been removed.  This check is bogus since we won't inc
rec->found_ref if we don't find a REF_KEY _and_ a DIR_ITEM, so we only have to
worry about there being no references to a root if it actually has a root item.
If it doesn't then it's just referenced by things that will go no where anyway.
With this patch fsck no longer incorrectly complains about this file system
image I have.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
 cmds-check.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/cmds-check.c b/cmds-check.c
index 4083298..68cdd52 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -1637,6 +1637,14 @@ static int check_root_refs(struct btrfs_root *root,
 						rec->objectid);
 			if (ret == 0)
 				continue;
+
+			/*
+			 * If we don't have a root item then we likely just have
+			 * a dir item in a snapshot for this root but no actual
+			 * ref key or anything so it's meaningless.
+			 */
+			if (!rec->found_root_item)
+				continue;
 			errors++;
 			fprintf(stderr, "fs tree %llu not referenced\n",
 				(unsigned long long)rec->objectid);
-- 
1.7.7.6


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-06-05 14:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 14:12 [PATCH] Btrfs-progs: fix reference check for roots in btrfsck Josef Bacik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).