From: Josef Bacik <jbacik@fusionio.com>
To: <xfs@oss.sgi.com>, <linux-btrfs@vger.kernel.org>
Subject: [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch
Date: Wed, 26 Jun 2013 11:49:28 -0400 [thread overview]
Message-ID: <1372261768-1795-1-git-send-email-jbacik@fusionio.com> (raw)
If you use the SCRATCH_DEV_POOL for btrfs you will end up with the command line
like this
mkfs.btrfs $SCRATCH_DEV_POOL $SCRATCH_DEV
and btrfs does this thing where it makes the lowest valued device id show up in
/proc/mounts no matter which device you specify at the mount command. So in
this case mount will show the first device in $SCRATCH_DEV_POOL instead of
$SCRATCH_DEV, so anybody who wants to just use the scratch mnt with the scratch
dev will fail to work because we never unmount the scratch mount. Fix this by
checking to see if the scratch dev pool is mounted at scratch mnt and unmount it
so we can run our test. This fixes the issue I was seeing by running
./check btrfs/307 generic/015
Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
common/rc | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/common/rc b/common/rc
index ad7cbc9..7e03400 100644
--- a/common/rc
+++ b/common/rc
@@ -938,6 +938,8 @@ _supported_os()
#
_require_scratch()
{
+ local i
+
case "$FSTYP" in
nfs*)
echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
@@ -978,6 +980,17 @@ _require_scratch()
exit 1
fi
fi
+
+ # we may have a scratch dev pool specified, so make sure it's been unmounted
+ # from the scratch mount
+ for i in $SCRATCH_DEV_POOL; do
+ if _mount | grep $i | grep -q $SCRATCH_MNT; then
+ if ! $UMOUNT_PROG $i; then
+ echo "failed to umount $i - aborting"
+ exit 1
+ fi
+ fi
+ done
}
# this test needs a logdev
--
1.7.7.6
next reply other threads:[~2013-06-26 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:49 Josef Bacik [this message]
2013-06-26 19:18 ` [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch Zach Brown
2013-06-26 19:34 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372261768-1795-1-git-send-email-jbacik@fusionio.com \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).