linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Shilong <wangshilong1991@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz, sandeen@redhat.com
Subject: [PATCH 00/20] fix magic return value in btrfs-progs
Date: Wed,  4 Sep 2013 23:22:17 +0800	[thread overview]
Message-ID: <1378308157-4621-1-git-send-email-wangshilong1991@gmail.com> (raw)

This patchset tries to fix all the magic return value in btrfs-progs.
Most commands will have three kinds of return value:

0 success
1 usage of syntax errors

Exceptions come from balance/scrub/replace. For example, replace cancel
will return 2 if there is no operations in progress.

Some tools including(btrfsck,chunk-recover) since they are still under
development. Also we should update man page if these magic return values
have been corrected.

Any comments are welcome.

Notice: this patchset is based on David integration-20130902

Wang Shilong (20):
  Btrfs-progs: return 1 rather than 129 in usage()
  Btrfs-progs: fix magic return value in cmds-subvolume.c
  Btrfs-progs: fix magic return value in cmds-chunk.c
  Btrfs-progs: fix magic return value in cmds-dedup.c
  Btrfs-progs: fix magic return value in cmds-device.c
  Btrfs-progs: fix magic return value in cmds-filesystem.c
  Btrfs-progs: fix magic return value in cmds-inspect.c
  Btrfs-progs: fix magic return value in cmds-qgroup.c
  Btrfs-progs: fix magic return value in cmds-quota.c
  Btrfs-progs: fix magic return value in cmds-receive.c
  Btrfs-progs: fix magic return value in cmds-restore.c
  Btrfs-progs: fix magic return value in cmds-send.c
  Btrfs-progs: fix magic return value in btrfs-imgae.c
  Btrfs-progs: fix magic return value in btrfs-zero-log.c
  Btrfs-progs: fix magic return value in send-test.c
  Btrfs-progs: fix magic return value in dir-test.c
  Btrfs-progs: fix magic return value in random-test.c
  Btrfs-progs: fix magic return value in cmds-balance.c
  Btrfs-progs: fix magic return value in cmds-replace.c
  Btrfs-progs: fix magic return value in cmds-scrub.c

 btrfs-image.c     |  2 +-
 btrfs-zero-log.c  |  8 +++--
 cmds-balance.c    | 93 ++++++++++++++++++++++++++++++++++---------------------
 cmds-chunk.c      |  9 ++++--
 cmds-dedup.c      |  6 ++--
 cmds-device.c     | 24 ++++++--------
 cmds-filesystem.c | 28 ++++++++---------
 cmds-inspect.c    | 10 +++---
 cmds-qgroup.c     | 26 +++++++---------
 cmds-quota.c      | 10 +++---
 cmds-receive.c    |  4 +--
 cmds-replace.c    | 16 ++++++----
 cmds-restore.c    | 18 +++++------
 cmds-scrub.c      | 20 ++++++------
 cmds-send.c       |  2 +-
 cmds-subvolume.c  | 45 ++++++++++++---------------
 dir-test.c        | 16 +++++-----
 help.c            |  2 +-
 random-test.c     | 18 +++++------
 send-test.c       |  2 +-
 20 files changed, 189 insertions(+), 170 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2013-09-04 15:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 15:22 Wang Shilong [this message]
2013-09-04 15:22 ` [PATCH 01/20] Btrfs-progs: return 1 rather than 129 in usage() Wang Shilong
2013-09-04 15:22 ` [PATCH 02/20] Btrfs-progs: fix magic return value in cmds-subvolume.c Wang Shilong
2013-09-04 15:22 ` [PATCH 03/20] Btrfs-progs: fix magic return value in cmds-chunk.c Wang Shilong
2013-09-04 15:22 ` [PATCH 04/20] Btrfs-progs: fix magic return value in cmds-dedup.c Wang Shilong
2013-09-04 15:22 ` [PATCH 05/20] Btrfs-progs: fix magic return value in cmds-device.c Wang Shilong
2013-09-04 15:22 ` [PATCH 06/20] Btrfs-progs: fix magic return value in cmds-filesystem.c Wang Shilong
2013-09-04 15:22 ` [PATCH 07/20] Btrfs-progs: fix magic return value in cmds-inspect.c Wang Shilong
2013-09-04 15:22 ` [PATCH 08/20] Btrfs-progs: fix magic return value in cmds-qgroup.c Wang Shilong
2013-09-04 15:22 ` [PATCH 09/20] Btrfs-progs: fix magic return value in cmds-quota.c Wang Shilong
2013-09-04 15:22 ` [PATCH 10/20] Btrfs-progs: fix magic return value in cmds-receive.c Wang Shilong
2013-09-04 15:22 ` [PATCH 11/20] Btrfs-progs: fix magic return value in cmds-restore.c Wang Shilong
2013-09-04 15:22 ` [PATCH 12/20] Btrfs-progs: fix magic return value in cmds-send.c Wang Shilong
2013-09-04 15:22 ` [PATCH 13/20] Btrfs-progs: fix magic return value in btrfs-imgae.c Wang Shilong
2013-09-04 15:22 ` [PATCH 14/20] Btrfs-progs: fix magic return value in btrfs-zero-log.c Wang Shilong
2013-09-04 15:22 ` [PATCH 15/20] Btrfs-progs: fix magic return value in send-test.c Wang Shilong
2013-09-04 15:22 ` [PATCH 16/20] Btrfs-progs: fix magic return value in dir-test.c Wang Shilong
2013-09-04 15:22 ` [PATCH 17/20] Btrfs-progs: fix magic return value in random-test.c Wang Shilong
2013-09-04 15:22 ` [PATCH 18/20] Btrfs-progs: fix magic return value in cmds-balance.c Wang Shilong
2013-09-04 16:26   ` Ilya Dryomov
2013-09-05  7:44     ` Wang Shilong
2013-09-05  8:21       ` Stefan Behrens
2013-09-05  8:23         ` Wang Shilong
2013-09-04 15:22 ` [PATCH 19/20] Btrfs-progs: fix magic return value in cmds-replace.c Wang Shilong
2013-09-04 15:22 ` [PATCH 20/20] Btrfs-progs: fix magic return value in cmds-scrub.c Wang Shilong
2013-09-05  2:14 ` [PATCH 00/20] fix magic return value in btrfs-progs Anand Jain
2013-09-05  8:30   ` Wang Shilong
2013-09-09 14:08   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378308157-4621-1-git-send-email-wangshilong1991@gmail.com \
    --to=wangshilong1991@gmail.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).