From: Josef Bacik <jbacik@fusionio.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <walken@google.com>, <linux-kernel@vger.kernel.org>,
<mingo@elte.hu>, <peter@hurleysoftware.com>,
<akpm@linux-foundation.org>
Subject: [PATCH 1/2] rwsem: add rwsem_is_contended V2
Date: Thu, 19 Sep 2013 11:48:07 -0400 [thread overview]
Message-ID: <1379605688-987-1-git-send-email-jbacik@fusionio.com> (raw)
Btrfs needs a simple way to know if it needs to let go of it's read lock on a
rwsem. Introduce rwsem_is_contended to check to see if there are any waiters on
this rwsem currently. This is just a hueristic, it is meant to be light and not
100% accurate and called by somebody already holding on to the rwsem in either
read or write. Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
V1->V2: took everybodys suggestions and simplified it to just one function in
rwsem.h so it works for both the spinlock case and non-spinlock case.
include/linux/rwsem.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 0616ffe..c340493 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -75,6 +75,19 @@ do { \
} while (0)
/*
+ * This is the same regardless of which rwsem implementation that is being used.
+ * It is just a heuristic meant to be called by somebody alreadying holding the
+ * rwsem to see if somebody from the opposite type is wanting access to the
+ * lock.
+ */
+static inline int rwsem_is_contended(struct rw_semaphore *sem)
+{
+ if (!list_empty(&sem->wait_list))
+ return 1;
+ return 0;
+}
+
+/*
* lock for reading
*/
extern void down_read(struct rw_semaphore *sem);
--
1.8.3.1
next reply other threads:[~2013-09-19 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 15:48 Josef Bacik [this message]
2013-09-19 15:48 ` [PATCH 2/2] Btrfs: stop caching thread if extetn_commit_sem is contended Josef Bacik
2013-09-20 5:12 ` Ingo Molnar
2013-09-26 12:40 ` Josef Bacik
2013-09-26 12:43 ` Ingo Molnar
2013-09-19 22:57 ` [PATCH 1/2] rwsem: add rwsem_is_contended V2 Peter Hurley
2013-09-19 23:27 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379605688-987-1-git-send-email-jbacik@fusionio.com \
--to=jbacik@fusionio.com \
--cc=akpm@linux-foundation.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter@hurleysoftware.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).