From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH 3/3] btrfs-progs: add more parameter to the filesystem show
Date: Fri, 27 Sep 2013 20:24:43 +0800 [thread overview]
Message-ID: <1380284683-3751-3-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1380284683-3751-1-git-send-email-anand.jain@oracle.com>
for mounted btrfs filesystem this patch proposes to add
information to also show the mount point and group profile,
to help user to quickly understand near details of the
btrfs filesystem
end user using this new btrfs fi show would surely notice this
will reduce other commands normally used following the current
btrfs fi show command. (like mount and btrfs fi df). of course
user should use fi df to know detailed info about the sizes.
preview as below..
Label: none uuid: 26d539a5-8968-4cf0-b4b5-5fd50105f8a0 mounted: /btrfs
Group profile: Metadata: single Metadata: DUP Data: single
Total devices 1 FS bytes used 28.00KiB
devid 1 size 1.98GiB used 238.25MiB path /dev/mapper/mpatha
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
cmds-filesystem.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 5300060..064841b 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -270,10 +270,21 @@ static int print_one_fs(struct btrfs_ioctl_fs_info_args *fs_info,
int i;
char uuidbuf[37];
struct btrfs_ioctl_dev_info_args *tmp_dev_info;
+ u64 flags;
uuid_unparse(fs_info->fsid, uuidbuf);
- printf("Label: %s uuid: %s\n",
- strlen(label) ? label : "none", uuidbuf);
+ printf("Label: %s uuid: %s mounted: %s\n",
+ strlen(label) ? label : "none", uuidbuf, path);
+ printf("\tGroup profile:");
+ for (i = space_info->total_spaces - 1; i >= 0; i--) {
+ flags = space_info->spaces[i].flags;
+ if (flags & BTRFS_BLOCK_GROUP_SYSTEM)
+ continue;
+ printf(" %s: %s", group_type_str(flags),
+ group_profile_str(flags));
+ printf(" ");
+ }
+ printf("\n");
printf("\tTotal devices %llu FS bytes used %s\n",
fs_info->num_devices,
--
1.8.4.rc4.1.g0d8beaa
prev parent reply other threads:[~2013-09-27 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 12:24 [PATCH 1/3 v6] btrfs-progs: move out print in cmd_df to another function Anand Jain
2013-09-27 12:24 ` [PATCH 2/3 v3] btrfs-progs: use kernel for mounted disk for show Anand Jain
2013-09-27 12:24 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380284683-3751-3-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).