* [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
@ 2013-10-21 16:05 Josef Bacik
2013-10-21 19:59 ` Eric Sandeen
2013-10-22 21:19 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Josef Bacik @ 2013-10-21 16:05 UTC (permalink / raw)
To: linux-btrfs, xfs
I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok
to mkfs an entire device. We need -F so it doesn't ask this question. Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
tests/btrfs/012 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/012 b/tests/btrfs/012
index de90149..f7e5da5 100755
--- a/tests/btrfs/012
+++ b/tests/btrfs/012
@@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck
rm -f $seqres.full
# Create & populate an ext4 filesystem
-$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
+$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
_notrun "Could not create ext4 filesystem"
# Manual mount so we don't use -t btrfs or selinux context
mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
2013-10-21 16:05 [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012 Josef Bacik
@ 2013-10-21 19:59 ` Eric Sandeen
2013-10-22 21:19 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-10-21 19:59 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-btrfs, xfs
On 10/21/13 11:05 AM, Josef Bacik wrote:
> I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok
> to mkfs an entire device. We need -F so it doesn't ask this question. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> tests/btrfs/012 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index de90149..f7e5da5 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck
> rm -f $seqres.full
>
> # Create & populate an ext4 filesystem
> -$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
> +$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \
> _notrun "Could not create ext4 filesystem"
> # Manual mount so we don't use -t btrfs or selinux context
> mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
2013-10-21 16:05 [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012 Josef Bacik
2013-10-21 19:59 ` Eric Sandeen
@ 2013-10-22 21:19 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-10-22 21:19 UTC (permalink / raw)
To: Josef Bacik, linux-btrfs, xfs
This has been committed.
Thanks
--Rich
commit 0c6fb9f3acb4bca2c4abebaf92ed5bb48472cae0
Author: Josef Bacik <jbacik@fusionio.com>
Date: Mon Oct 21 16:05:16 2013 +0000
xfstests: use -F for mkfs.ext4 in btrfs/012
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-22 21:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 16:05 [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012 Josef Bacik
2013-10-21 19:59 ` Eric Sandeen
2013-10-22 21:19 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).