* [PATCH] btrfs: add framework to read fs info from btrfs-control
@ 2013-10-25 17:10 Anand Jain
2013-10-29 21:33 ` Zach Brown
0 siblings, 1 reply; 6+ messages in thread
From: Anand Jain @ 2013-10-25 17:10 UTC (permalink / raw)
To: linux-btrfs
This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
info through the btrfs-control
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/super.c | 47 ++++++++++++++++++++++++++++++++++++++-----
fs/btrfs/volumes.c | 33 ++++++++++++++++++++++++++++++
fs/btrfs/volumes.h | 2 +
include/uapi/linux/btrfs.h | 19 +++++++++++++++++
4 files changed, 95 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 0991fb1..bae53ba 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1641,38 +1641,73 @@ static struct file_system_type btrfs_fs_type = {
};
MODULE_ALIAS_FS("btrfs");
+static int btrfs_ioc_get_fslist(void __user *arg)
+{
+ int ret = 0;
+ u64 sz_fslist_arg;
+ u64 sz_fslist;
+ struct btrfs_ioctl_fslist_args *fslist_arg;
+ struct btrfs_ioctl_fslist *fslist;
+
+ sz_fslist_arg = sizeof(*fslist_arg);
+ fslist_arg = memdup_user(arg, sz_fslist_arg);
+
+ sz_fslist = sizeof(*fslist) * fslist_arg->count;
+ kfree(fslist_arg);
+ fslist_arg = memdup_user(arg, sz_fslist_arg + sz_fslist);
+ fslist = (struct btrfs_ioctl_fslist *) (fslist_arg + sz_fslist_arg);
+
+ ret = btrfs_get_fslist(fslist_arg, fslist);
+
+ fslist->self_sz = sz_fslist;
+ fslist_arg->self_sz = sz_fslist_arg;
+
+ if (copy_to_user(arg, fslist_arg, sz_fslist_arg + sz_fslist))
+ ret = -EFAULT;
+
+ kfree(fslist_arg);
+ return ret;
+}
+
/*
* used by btrfsctl to scan devices when no FS is mounted
*/
static long btrfs_control_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
- struct btrfs_ioctl_vol_args *vol;
+ struct btrfs_ioctl_vol_args *vol = NULL;
struct btrfs_fs_devices *fs_devices;
int ret = -ENOTTY;
+ void __user *argp = (void __user *)arg;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
- vol = memdup_user((void __user *)arg, sizeof(*vol));
- if (IS_ERR(vol))
- return PTR_ERR(vol);
-
switch (cmd) {
case BTRFS_IOC_SCAN_DEV:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
break;
case BTRFS_IOC_DEVICES_READY:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
if (ret)
break;
ret = !(fs_devices->num_devices == fs_devices->total_devices);
break;
+ case BTRFS_IOC_GET_FSLIST:
+ ret = btrfs_ioc_get_fslist(argp);
+ break;
}
- kfree(vol);
return ret;
}
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index fe0f2ef..a7b8f26 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6284,3 +6284,36 @@ int btrfs_scratch_superblock(struct btrfs_device *device)
return 0;
}
+
+/* return 1 if allocation count exceed the num of fs list
+ * in the kernel
+ */
+int btrfs_get_fslist(struct btrfs_ioctl_fslist_args *fslist_arg,
+ struct btrfs_ioctl_fslist *fslist)
+{
+ u64 cnt = 0, ucnt;
+ struct btrfs_fs_devices *fs_devices;
+
+ ucnt = fslist_arg->count;
+
+ list_for_each_entry(fs_devices, &fs_uuids, list) {
+ if (cnt < ucnt) {
+ memcpy(fslist->fsid, fs_devices->fsid,
+ BTRFS_FSID_SIZE);
+ fslist->num_devices = fs_devices->num_devices;
+ fslist->missing_devices = fs_devices->missing_devices;
+ fslist->total_devices = fs_devices->total_devices;
+
+ if (fs_devices->opened)
+ fslist->flags = BTRFS_FS_MOUNTED;
+
+ fslist = (struct btrfs_ioctl_fslist *) fslist +
+ sizeof(*fslist);
+ }
+ cnt++;
+ }
+ fslist_arg->count = cnt;
+ if (cnt > ucnt)
+ return 1;
+ return 0;
+}
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index b72f540..e68a1c8 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -388,4 +388,6 @@ static inline void btrfs_dev_stat_reset(struct btrfs_device *dev,
{
btrfs_dev_stat_set(dev, index, 0);
}
+int btrfs_get_fslist(struct btrfs_ioctl_fslist_args *fslist_arg,
+ struct btrfs_ioctl_fslist *fslist);
#endif
diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 45e6189..6690551 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -512,6 +512,23 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
}
}
+/* fs flags */
+#define BTRFS_FS_MOUNTED (1LLU << 0)
+
+struct btrfs_ioctl_fslist {
+ __u64 self_sz; /* in/out */
+ __u8 fsid[BTRFS_FSID_SIZE]; /* out */
+ __u64 num_devices;
+ __u64 missing_devices;
+ __u64 total_devices;
+ __u64 flags;
+};
+
+struct btrfs_ioctl_fslist_args {
+ __u64 self_sz; /* in/out */
+ __u64 count; /* out */
+};
+
#define BTRFS_IOC_SNAP_CREATE _IOW(BTRFS_IOCTL_MAGIC, 1, \
struct btrfs_ioctl_vol_args)
#define BTRFS_IOC_DEFRAG _IOW(BTRFS_IOCTL_MAGIC, 2, \
@@ -606,5 +623,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
struct btrfs_ioctl_dev_replace_args)
#define BTRFS_IOC_FILE_EXTENT_SAME _IOWR(BTRFS_IOCTL_MAGIC, 54, \
struct btrfs_ioctl_same_args)
+#define BTRFS_IOC_GET_FSLIST _IOWR(BTRFS_IOCTL_MAGIC, 56, \
+ struct btrfs_ioctl_fslist_args)
#endif /* _UAPI_LINUX_BTRFS_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: add framework to read fs info from btrfs-control
2013-10-25 17:10 [PATCH] " Anand Jain
@ 2013-10-29 21:33 ` Zach Brown
2013-11-04 3:39 ` Anand Jain
0 siblings, 1 reply; 6+ messages in thread
From: Zach Brown @ 2013-10-29 21:33 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs
> This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
> info through the btrfs-control
Why not use sysfs?
> + sz_fslist_arg = sizeof(*fslist_arg);
> + fslist_arg = memdup_user(arg, sz_fslist_arg);
Doesn't check allocation failure.
> +
> + sz_fslist = sizeof(*fslist) * fslist_arg->count;
> + kfree(fslist_arg);
That allocation and copy and free gets a single u64. Use
copy_from_user() for the u64.
> + fslist_arg = memdup_user(arg, sz_fslist_arg + sz_fslist);
Allocates an arbitrarily huge size that depends only on user input.
Doesn't check failure again. And I bet you can scribble on kernel
memory if you wrap the size.
> + if (copy_to_user(arg, fslist_arg, sz_fslist_arg + sz_fslist))
> + ret = -EFAULT;
And there's no reason to buffer all this in the kernel to begin with.
Just copy_to_user() as you iterate over each fs_devices.
> + fslist = (struct btrfs_ioctl_fslist *) fslist +
> + sizeof(*fslist);
AKA fslist++.
- z
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: add framework to read fs info from btrfs-control
2013-10-29 21:33 ` Zach Brown
@ 2013-11-04 3:39 ` Anand Jain
0 siblings, 0 replies; 6+ messages in thread
From: Anand Jain @ 2013-11-04 3:39 UTC (permalink / raw)
To: Zach Brown; +Cc: linux-btrfs
(sorry for the delay, various external issues)
I have sent out the new patch set. Thanks for the comments.
more inline.
On 10/30/13 05:33 AM, Zach Brown wrote:
>
>> This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
>> info through the btrfs-control
>
> Why not use sysfs?
various sysfs interface for btrfs is still being a RFC
ioctl would much simpler to get the bug fixed.
>> + sz_fslist_arg = sizeof(*fslist_arg);
>> + fslist_arg = memdup_user(arg, sz_fslist_arg);
>
> Doesn't check allocation failure.
fixed it.
>> +
>> + sz_fslist = sizeof(*fslist) * fslist_arg->count;
>> + kfree(fslist_arg);
>
> That allocation and copy and free gets a single u64. Use
> copy_from_user() for the u64.
oh yes. thanks.
>> + fslist_arg = memdup_user(arg, sz_fslist_arg + sz_fslist);
>
> Allocates an arbitrarily huge size that depends only on user input.
> Doesn't check failure again. And I bet you can scribble on kernel
> memory if you wrap the size.
fixed it. now it finds the number of fsid and then allocates mem.
>> + if (copy_to_user(arg, fslist_arg, sz_fslist_arg + sz_fslist))
>> + ret = -EFAULT;
>
> And there's no reason to buffer all this in the kernel to begin with.
> Just copy_to_user() as you iterate over each fs_devices.
Ok in the v2 patch I have narrowed the allocation and copy to
just what is present. but I still feel one-shot copy is better.
Now I have also used uuid_mutex its bit less granular for the
purpose here but taking into consideration that thread is from
btrfs-control (and so no root pointer is readily available) for
which it should be fine IMO. any comments. thanks.
>> + fslist = (struct btrfs_ioctl_fslist *) fslist +
>> + sizeof(*fslist);
>
> AKA fslist++.
fixed it.
> - z
Posted V2.
Thanks, Anand
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] btrfs: add framework to read fs info from btrfs-control
@ 2013-11-04 3:45 Anand Jain
2013-11-04 4:34 ` [PATCH v2] " Anand Jain
2013-12-19 3:59 ` [PATCH v3] " Anand Jain
0 siblings, 2 replies; 6+ messages in thread
From: Anand Jain @ 2013-11-04 3:45 UTC (permalink / raw)
To: linux-btrfs; +Cc: jbacik, zab, dsterba
This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
info through the btrfs-control
v2: accepts Zach suggested
now holds uuid_mutex
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/super.c | 66 ++++++++++++++++++++++++++++++++++++++++----
fs/btrfs/volumes.c | 39 ++++++++++++++++++++++++++
fs/btrfs/volumes.h | 2 +
include/uapi/linux/btrfs.h | 19 ++++++++++++
4 files changed, 120 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index e9c4e41..241f401 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1646,38 +1646,92 @@ static struct file_system_type btrfs_fs_type = {
};
MODULE_ALIAS_FS("btrfs");
+static int btrfs_ioc_get_fslist(void __user *arg)
+{
+ int ret = 0;
+ u64 sz_fslist_arg;
+ u64 sz_fslist;
+ u64 sz_out;
+ struct btrfs_ioctl_fslist_args *fslist_arg;
+ struct btrfs_ioctl_fslist_args *fslist_arg_tmp;
+ struct btrfs_ioctl_fslist *fslist;
+
+ u64 cnt = 0, ucnt;
+
+ sz_fslist_arg = sizeof(*fslist_arg);
+ sz_fslist = sizeof(*fslist);
+ if (copy_from_user(&ucnt,
+ (struct btrfs_ioctl_fslist_args __user *)(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count)),
+ sizeof(ucnt)))
+ return -EFAULT;
+
+ cnt = btrfs_get_fslist_cnt();
+
+ if (cnt > ucnt) {
+ if (copy_to_user(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count),
+ &cnt, sizeof(cnt)))
+ return -EFAULT;
+ return 1;
+ }
+
+ sz_out = sz_fslist_arg + sz_fslist * cnt;
+ fslist_arg_tmp = fslist_arg = memdup_user(arg, sz_out);
+ if (IS_ERR(fslist_arg))
+ return PTR_ERR(fslist_arg);
+ fslist = (struct btrfs_ioctl_fslist *) (++fslist_arg_tmp);
+ cnt = btrfs_get_fslist(fslist, cnt);
+ fslist_arg->count = cnt;
+ if (copy_to_user(arg, fslist_arg, sz_out)) {
+ ret = -EFAULT;
+ goto out;
+ }
+ ret = 0;
+out:
+ kfree(fslist_arg);
+ return ret;
+}
+
/*
* used by btrfsctl to scan devices when no FS is mounted
*/
static long btrfs_control_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
- struct btrfs_ioctl_vol_args *vol;
+ struct btrfs_ioctl_vol_args *vol = NULL;
struct btrfs_fs_devices *fs_devices;
int ret = -ENOTTY;
+ void __user *argp = (void __user *)arg;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
- vol = memdup_user((void __user *)arg, sizeof(*vol));
- if (IS_ERR(vol))
- return PTR_ERR(vol);
-
switch (cmd) {
case BTRFS_IOC_SCAN_DEV:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
break;
case BTRFS_IOC_DEVICES_READY:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
if (ret)
break;
ret = !(fs_devices->num_devices == fs_devices->total_devices);
break;
+ case BTRFS_IOC_GET_FSLIST:
+ ret = btrfs_ioc_get_fslist(argp);
+ break;
}
- kfree(vol);
return ret;
}
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 5103cfe..b114372 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6289,3 +6289,42 @@ int btrfs_scratch_superblock(struct btrfs_device *device)
return 0;
}
+
+int btrfs_get_fslist_cnt(void)
+{
+ int cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list)
+ cnt++;
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
+
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt)
+{
+ u64 cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list) {
+ if (!(cnt < ucnt))
+ break;
+ memcpy(fslist->fsid, fs_devices->fsid,
+ BTRFS_FSID_SIZE);
+ fslist->num_devices = fs_devices->num_devices;
+ fslist->missing_devices = fs_devices->missing_devices;
+ fslist->total_devices = fs_devices->total_devices;
+
+ if (fs_devices->opened)
+ fslist->flags = BTRFS_FS_MOUNTED;
+
+ fslist++;
+ cnt++;
+ }
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index b72f540..d8079e6 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -388,4 +388,6 @@ static inline void btrfs_dev_stat_reset(struct btrfs_device *dev,
{
btrfs_dev_stat_set(dev, index, 0);
}
+int btrfs_get_fslist_cnt(void);
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt);
#endif
diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 45e6189..6690551 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -512,6 +512,23 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
}
}
+/* fs flags */
+#define BTRFS_FS_MOUNTED (1LLU << 0)
+
+struct btrfs_ioctl_fslist {
+ __u64 self_sz; /* in/out */
+ __u8 fsid[BTRFS_FSID_SIZE]; /* out */
+ __u64 num_devices;
+ __u64 missing_devices;
+ __u64 total_devices;
+ __u64 flags;
+};
+
+struct btrfs_ioctl_fslist_args {
+ __u64 self_sz; /* in/out */
+ __u64 count; /* out */
+};
+
#define BTRFS_IOC_SNAP_CREATE _IOW(BTRFS_IOCTL_MAGIC, 1, \
struct btrfs_ioctl_vol_args)
#define BTRFS_IOC_DEFRAG _IOW(BTRFS_IOCTL_MAGIC, 2, \
@@ -606,5 +623,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
struct btrfs_ioctl_dev_replace_args)
#define BTRFS_IOC_FILE_EXTENT_SAME _IOWR(BTRFS_IOCTL_MAGIC, 54, \
struct btrfs_ioctl_same_args)
+#define BTRFS_IOC_GET_FSLIST _IOWR(BTRFS_IOCTL_MAGIC, 56, \
+ struct btrfs_ioctl_fslist_args)
#endif /* _UAPI_LINUX_BTRFS_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] btrfs: add framework to read fs info from btrfs-control
2013-11-04 3:45 [PATCH] btrfs: add framework to read fs info from btrfs-control Anand Jain
@ 2013-11-04 4:34 ` Anand Jain
2013-12-19 3:59 ` [PATCH v3] " Anand Jain
1 sibling, 0 replies; 6+ messages in thread
From: Anand Jain @ 2013-11-04 4:34 UTC (permalink / raw)
To: linux-btrfs
This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
info through the btrfs-control
v2: accepts Zach suggested
now holds uuid_mutex
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/super.c | 66 ++++++++++++++++++++++++++++++++++++++++----
fs/btrfs/volumes.c | 39 ++++++++++++++++++++++++++
fs/btrfs/volumes.h | 2 +
include/uapi/linux/btrfs.h | 19 ++++++++++++
4 files changed, 120 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index e9c4e41..241f401 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1646,38 +1646,92 @@ static struct file_system_type btrfs_fs_type = {
};
MODULE_ALIAS_FS("btrfs");
+static int btrfs_ioc_get_fslist(void __user *arg)
+{
+ int ret = 0;
+ u64 sz_fslist_arg;
+ u64 sz_fslist;
+ u64 sz_out;
+ struct btrfs_ioctl_fslist_args *fslist_arg;
+ struct btrfs_ioctl_fslist_args *fslist_arg_tmp;
+ struct btrfs_ioctl_fslist *fslist;
+
+ u64 cnt = 0, ucnt;
+
+ sz_fslist_arg = sizeof(*fslist_arg);
+ sz_fslist = sizeof(*fslist);
+ if (copy_from_user(&ucnt,
+ (struct btrfs_ioctl_fslist_args __user *)(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count)),
+ sizeof(ucnt)))
+ return -EFAULT;
+
+ cnt = btrfs_get_fslist_cnt();
+
+ if (cnt > ucnt) {
+ if (copy_to_user(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count),
+ &cnt, sizeof(cnt)))
+ return -EFAULT;
+ return 1;
+ }
+
+ sz_out = sz_fslist_arg + sz_fslist * cnt;
+ fslist_arg_tmp = fslist_arg = memdup_user(arg, sz_out);
+ if (IS_ERR(fslist_arg))
+ return PTR_ERR(fslist_arg);
+ fslist = (struct btrfs_ioctl_fslist *) (++fslist_arg_tmp);
+ cnt = btrfs_get_fslist(fslist, cnt);
+ fslist_arg->count = cnt;
+ if (copy_to_user(arg, fslist_arg, sz_out)) {
+ ret = -EFAULT;
+ goto out;
+ }
+ ret = 0;
+out:
+ kfree(fslist_arg);
+ return ret;
+}
+
/*
* used by btrfsctl to scan devices when no FS is mounted
*/
static long btrfs_control_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
- struct btrfs_ioctl_vol_args *vol;
+ struct btrfs_ioctl_vol_args *vol = NULL;
struct btrfs_fs_devices *fs_devices;
int ret = -ENOTTY;
+ void __user *argp = (void __user *)arg;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
- vol = memdup_user((void __user *)arg, sizeof(*vol));
- if (IS_ERR(vol))
- return PTR_ERR(vol);
-
switch (cmd) {
case BTRFS_IOC_SCAN_DEV:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
break;
case BTRFS_IOC_DEVICES_READY:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
if (ret)
break;
ret = !(fs_devices->num_devices == fs_devices->total_devices);
break;
+ case BTRFS_IOC_GET_FSLIST:
+ ret = btrfs_ioc_get_fslist(argp);
+ break;
}
- kfree(vol);
return ret;
}
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 5103cfe..b114372 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6289,3 +6289,42 @@ int btrfs_scratch_superblock(struct btrfs_device *device)
return 0;
}
+
+int btrfs_get_fslist_cnt(void)
+{
+ int cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list)
+ cnt++;
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
+
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt)
+{
+ u64 cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list) {
+ if (!(cnt < ucnt))
+ break;
+ memcpy(fslist->fsid, fs_devices->fsid,
+ BTRFS_FSID_SIZE);
+ fslist->num_devices = fs_devices->num_devices;
+ fslist->missing_devices = fs_devices->missing_devices;
+ fslist->total_devices = fs_devices->total_devices;
+
+ if (fs_devices->opened)
+ fslist->flags = BTRFS_FS_MOUNTED;
+
+ fslist++;
+ cnt++;
+ }
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index b72f540..d8079e6 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -388,4 +388,6 @@ static inline void btrfs_dev_stat_reset(struct btrfs_device *dev,
{
btrfs_dev_stat_set(dev, index, 0);
}
+int btrfs_get_fslist_cnt(void);
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt);
#endif
diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 45e6189..6690551 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -512,6 +512,23 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
}
}
+/* fs flags */
+#define BTRFS_FS_MOUNTED (1LLU << 0)
+
+struct btrfs_ioctl_fslist {
+ __u64 self_sz; /* in/out */
+ __u8 fsid[BTRFS_FSID_SIZE]; /* out */
+ __u64 num_devices;
+ __u64 missing_devices;
+ __u64 total_devices;
+ __u64 flags;
+};
+
+struct btrfs_ioctl_fslist_args {
+ __u64 self_sz; /* in/out */
+ __u64 count; /* out */
+};
+
#define BTRFS_IOC_SNAP_CREATE _IOW(BTRFS_IOCTL_MAGIC, 1, \
struct btrfs_ioctl_vol_args)
#define BTRFS_IOC_DEFRAG _IOW(BTRFS_IOCTL_MAGIC, 2, \
@@ -606,5 +623,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
struct btrfs_ioctl_dev_replace_args)
#define BTRFS_IOC_FILE_EXTENT_SAME _IOWR(BTRFS_IOCTL_MAGIC, 54, \
struct btrfs_ioctl_same_args)
+#define BTRFS_IOC_GET_FSLIST _IOWR(BTRFS_IOCTL_MAGIC, 56, \
+ struct btrfs_ioctl_fslist_args)
#endif /* _UAPI_LINUX_BTRFS_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3] btrfs: add framework to read fs info from btrfs-control
2013-11-04 3:45 [PATCH] btrfs: add framework to read fs info from btrfs-control Anand Jain
2013-11-04 4:34 ` [PATCH v2] " Anand Jain
@ 2013-12-19 3:59 ` Anand Jain
1 sibling, 0 replies; 6+ messages in thread
From: Anand Jain @ 2013-12-19 3:59 UTC (permalink / raw)
To: linux-btrfs; +Cc: jbacik
This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs
info through the btrfs-control, needed to optimize
heavily used btrfs-progs function check_mounted()
plus few other minor uses.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v3: rebase and update commit
v2: accepts Zach suggested and now holds uuid_mutex
fs/btrfs/super.c | 66 ++++++++++++++++++++++++++++++++++++++++----
fs/btrfs/volumes.c | 39 ++++++++++++++++++++++++++
fs/btrfs/volumes.h | 2 +
include/uapi/linux/btrfs.h | 19 ++++++++++++
4 files changed, 120 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 0d4b1c3..13884c5 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1645,38 +1645,92 @@ static struct file_system_type btrfs_fs_type = {
};
MODULE_ALIAS_FS("btrfs");
+static int btrfs_ioc_get_fslist(void __user *arg)
+{
+ int ret = 0;
+ u64 sz_fslist_arg;
+ u64 sz_fslist;
+ u64 sz_out;
+ struct btrfs_ioctl_fslist_args *fslist_arg;
+ struct btrfs_ioctl_fslist_args *fslist_arg_tmp;
+ struct btrfs_ioctl_fslist *fslist;
+
+ u64 cnt = 0, ucnt;
+
+ sz_fslist_arg = sizeof(*fslist_arg);
+ sz_fslist = sizeof(*fslist);
+ if (copy_from_user(&ucnt,
+ (struct btrfs_ioctl_fslist_args __user *)(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count)),
+ sizeof(ucnt)))
+ return -EFAULT;
+
+ cnt = btrfs_get_fslist_cnt();
+
+ if (cnt > ucnt) {
+ if (copy_to_user(arg +
+ offsetof(struct btrfs_ioctl_fslist_args, count),
+ &cnt, sizeof(cnt)))
+ return -EFAULT;
+ return 1;
+ }
+
+ sz_out = sz_fslist_arg + sz_fslist * cnt;
+ fslist_arg_tmp = fslist_arg = memdup_user(arg, sz_out);
+ if (IS_ERR(fslist_arg))
+ return PTR_ERR(fslist_arg);
+ fslist = (struct btrfs_ioctl_fslist *) (++fslist_arg_tmp);
+ cnt = btrfs_get_fslist(fslist, cnt);
+ fslist_arg->count = cnt;
+ if (copy_to_user(arg, fslist_arg, sz_out)) {
+ ret = -EFAULT;
+ goto out;
+ }
+ ret = 0;
+out:
+ kfree(fslist_arg);
+ return ret;
+}
+
/*
* used by btrfsctl to scan devices when no FS is mounted
*/
static long btrfs_control_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
- struct btrfs_ioctl_vol_args *vol;
+ struct btrfs_ioctl_vol_args *vol = NULL;
struct btrfs_fs_devices *fs_devices;
int ret = -ENOTTY;
+ void __user *argp = (void __user *)arg;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
- vol = memdup_user((void __user *)arg, sizeof(*vol));
- if (IS_ERR(vol))
- return PTR_ERR(vol);
-
switch (cmd) {
case BTRFS_IOC_SCAN_DEV:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
break;
case BTRFS_IOC_DEVICES_READY:
+ vol = memdup_user((void __user *)arg, sizeof(*vol));
+ if (IS_ERR(vol))
+ return PTR_ERR(vol);
ret = btrfs_scan_one_device(vol->name, FMODE_READ,
&btrfs_fs_type, &fs_devices);
+ kfree(vol);
if (ret)
break;
ret = !(fs_devices->num_devices == fs_devices->total_devices);
break;
+ case BTRFS_IOC_GET_FSLIST:
+ ret = btrfs_ioc_get_fslist(argp);
+ break;
}
- kfree(vol);
return ret;
}
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 92303f4..debd619 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6284,3 +6284,42 @@ int btrfs_scratch_superblock(struct btrfs_device *device)
return 0;
}
+
+int btrfs_get_fslist_cnt(void)
+{
+ int cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list)
+ cnt++;
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
+
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt)
+{
+ u64 cnt = 0;
+ struct btrfs_fs_devices *fs_devices;
+
+ mutex_lock(&uuid_mutex);
+ list_for_each_entry(fs_devices, &fs_uuids, list) {
+ if (!(cnt < ucnt))
+ break;
+ memcpy(fslist->fsid, fs_devices->fsid,
+ BTRFS_FSID_SIZE);
+ fslist->num_devices = fs_devices->num_devices;
+ fslist->missing_devices = fs_devices->missing_devices;
+ fslist->total_devices = fs_devices->total_devices;
+
+ if (fs_devices->opened)
+ fslist->flags = BTRFS_FS_MOUNTED;
+
+ fslist++;
+ cnt++;
+ }
+ mutex_unlock(&uuid_mutex);
+
+ return cnt;
+}
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index 8b3cd14..ebb0d0c 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -390,4 +390,6 @@ static inline void btrfs_dev_stat_reset(struct btrfs_device *dev,
{
btrfs_dev_stat_set(dev, index, 0);
}
+int btrfs_get_fslist_cnt(void);
+u64 btrfs_get_fslist(struct btrfs_ioctl_fslist *fslist, u64 ucnt);
#endif
diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 1b8a0f4..7d7f776 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -518,6 +518,23 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
}
}
+/* fs flags */
+#define BTRFS_FS_MOUNTED (1LLU << 0)
+
+struct btrfs_ioctl_fslist {
+ __u64 self_sz; /* in/out */
+ __u8 fsid[BTRFS_FSID_SIZE]; /* out */
+ __u64 num_devices;
+ __u64 missing_devices;
+ __u64 total_devices;
+ __u64 flags;
+};
+
+struct btrfs_ioctl_fslist_args {
+ __u64 self_sz; /* in/out */
+ __u64 count; /* out */
+};
+
#define BTRFS_IOC_SNAP_CREATE _IOW(BTRFS_IOCTL_MAGIC, 1, \
struct btrfs_ioctl_vol_args)
#define BTRFS_IOC_DEFRAG _IOW(BTRFS_IOCTL_MAGIC, 2, \
@@ -613,6 +630,8 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
struct btrfs_ioctl_dev_replace_args)
#define BTRFS_IOC_FILE_EXTENT_SAME _IOWR(BTRFS_IOCTL_MAGIC, 54, \
struct btrfs_ioctl_same_args)
+#define BTRFS_IOC_GET_FSLIST _IOWR(BTRFS_IOCTL_MAGIC, 56, \
+ struct btrfs_ioctl_fslist_args)
#define BTRFS_IOC_GET_FEATURES _IOR(BTRFS_IOCTL_MAGIC, 57, \
struct btrfs_ioctl_feature_flags)
#define BTRFS_IOC_SET_FEATURES _IOW(BTRFS_IOCTL_MAGIC, 57, \
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-19 3:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 3:45 [PATCH] btrfs: add framework to read fs info from btrfs-control Anand Jain
2013-11-04 4:34 ` [PATCH v2] " Anand Jain
2013-12-19 3:59 ` [PATCH v3] " Anand Jain
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 17:10 [PATCH] " Anand Jain
2013-10-29 21:33 ` Zach Brown
2013-11-04 3:39 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).