From: Chris Mason <clm@fb.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>
Cc: Josef Bacik <jbacik@fb.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: move the extent buffer radix tree into the fs_info
Date: Tue, 17 Dec 2013 01:19:39 +0000 [thread overview]
Message-ID: <1387243189.15080.2.camel@ret.masoncoding.com> (raw)
In-Reply-To: <20131217010627.GK6498@twin.jikos.cz>
On Tue, 2013-12-17 at 02:06 +0100, David Sterba wrote:
> On Mon, Dec 16, 2013 at 01:26:26PM -0500, Josef Bacik wrote:
> > I need to create a fake tree to test qgroups and I don't want to have to setup a
> > fake btree_inode. The fact is we only use the radix tree for the fs_info, so
> > everybody else who allocates an extent_io_tree is just wasting the space anyway.
> > This patch moves the radix tree and its lock into btrfs_fs_info so there is less
> > stuff I have to fake to do qgroup sanity tests. Thanks,
>
> This would make the fs_info::buffer_lock a global hotspot if
> alloc_extent_buffer and release_extent_buffer are called frequently.
>
But since the only place that was really using it was the metadata
btree, the lock shouldn't be hotter than before right?
-chris
next prev parent reply other threads:[~2013-12-17 1:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 18:26 [PATCH] Btrfs: move the extent buffer radix tree into the fs_info Josef Bacik
2013-12-17 1:06 ` David Sterba
2013-12-17 1:19 ` Chris Mason [this message]
2013-12-17 13:56 ` David Sterba
2013-12-17 14:56 ` Josef Bacik
2013-12-17 15:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387243189.15080.2.camel@ret.masoncoding.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).