* [PATCH] Btrfs: use late_initcall instead of module_init
@ 2014-02-01 21:27 Filipe David Borba Manana
2014-02-04 14:24 ` Tobias Klausmann
0 siblings, 1 reply; 2+ messages in thread
From: Filipe David Borba Manana @ 2014-02-01 21:27 UTC (permalink / raw)
To: linux-btrfs; +Cc: ainan, Filipe David Borba Manana
It seems that when init_btrfs_fs() is called, crc32c/crc32c-intel might
not always be already initialized, which results in the call to crypto_alloc_shash()
returning -ENOENT, as experienced by Ahmet who reported this.
Therefore make sure init_btrfs_fs() is called after crc32c is initialized (which
is at initialization level 6, module_init), by using late_initcall (which is at
initialization level 7) instead of module_init for btrfs.
Reported-and-Tested-by: Ahmet Inan <ainan@mathematik.uni-freiburg.de>
Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
---
fs/btrfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index c02f633..97cc241 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1996,7 +1996,7 @@ static void __exit exit_btrfs_fs(void)
btrfs_hash_exit();
}
-module_init(init_btrfs_fs)
+late_initcall(init_btrfs_fs);
module_exit(exit_btrfs_fs)
MODULE_LICENSE("GPL");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Btrfs: use late_initcall instead of module_init
2014-02-01 21:27 [PATCH] Btrfs: use late_initcall instead of module_init Filipe David Borba Manana
@ 2014-02-04 14:24 ` Tobias Klausmann
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klausmann @ 2014-02-04 14:24 UTC (permalink / raw)
To: linux-btrfs
Hey,
as discussed on IRC, this makes 3.14-rc1 able tomount brtfs
again. Key difference (aside from being (un)able to mount) is that
btrfs now actually shows up in /proc/filesystems, where with
vanilla 3.14-rc1 it does not.
Tested on an i5-3470T.
Tested-By: Tobias Klausmann <klausman@schwarzvogel.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-04 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-01 21:27 [PATCH] Btrfs: use late_initcall instead of module_init Filipe David Borba Manana
2014-02-04 14:24 ` Tobias Klausmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).