linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: jeffm@suse.com, dsterba@suse.cz, clm@fb.com
Subject: [PATCH 4/6 v2] btrfs: dev replace should replace the sysfs entry
Date: Tue,  3 Jun 2014 11:36:02 +0800	[thread overview]
Message-ID: <1401766564-7381-5-git-send-email-Anand.Jain@oracle.com> (raw)
In-Reply-To: <1401766564-7381-1-git-send-email-Anand.Jain@oracle.com>

when we replace the device its corresponding sysfs
entry has to be replaced as well

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 v2: the function name change applied here

 fs/btrfs/dev-replace.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 9f22905..1219982 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -36,6 +36,7 @@
 #include "check-integrity.h"
 #include "rcu-string.h"
 #include "dev-replace.h"
+#include "sysfs.h"
 
 static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 				       int scrub_ret);
@@ -562,6 +563,10 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 		fs_info->fs_devices->latest_bdev = tgt_device->bdev;
 	list_add(&tgt_device->dev_alloc_list, &fs_info->fs_devices->alloc_list);
 
+	/* replace the sysfs entry */
+	btrfs_kobj_rm_device(fs_info, src_device);
+	btrfs_kobj_add_device(fs_info, tgt_device);
+
 	btrfs_rm_dev_replace_blocked(fs_info);
 
 	btrfs_rm_dev_replace_srcdev(fs_info, src_device);
-- 
1.8.5.3


  parent reply	other threads:[~2014-06-03  3:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  3:35 [PATCH 0/6 v2] update sysfs per btrfs device operations Anand Jain
2014-06-03  3:35 ` [PATCH 1/6 v2] btrfs: rename add_device_membership to btrfs_kobj_add_device Anand Jain
2014-06-03 13:23   ` David Sterba
2014-06-03  3:36 ` [PATCH 2/6 v2] btrfs: dev delete should remove sysfs entry Anand Jain
2014-06-03 13:23   ` David Sterba
2014-06-03  3:36 ` [PATCH 3/6 v2] btrfs: dev add should add its " Anand Jain
2014-06-03 13:23   ` David Sterba
2014-06-03  3:36 ` Anand Jain [this message]
2014-06-03 13:39   ` [PATCH 4/6 v2] btrfs: dev replace should replace the " David Sterba
2014-06-03  3:36 ` [PATCH 5/6 v2] btrfs: create sprout should rename fsid on the sysfs as well Anand Jain
2014-06-03 13:41   ` David Sterba
2014-06-03  3:36 ` [PATCH 6/6 RFC v2] btrfs: revamp /sys/fs/btrfs/<fsid>/devices Anand Jain
2014-06-03 14:08   ` David Sterba
2014-06-04  4:03     ` Anand Jain
2014-06-20  9:53 ` [PATCH 0/6 v2] update sysfs per btrfs device operations David Sterba
2014-06-20 15:40   ` Chris Mason
2014-06-20 15:42   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401766564-7381-5-git-send-email-Anand.Jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.cz \
    --cc=jeffm@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).