From: Anand Jain <Anand.Jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH 1/2 v2] btrfs: device add must be sysloged
Date: Wed, 2 Jul 2014 09:37:31 +0800 [thread overview]
Message-ID: <1404265052-29424-1-git-send-email-Anand.Jain@oracle.com> (raw)
In-Reply-To: <1404147537-19873-1-git-send-email-Anand.Jain@oracle.com>
when we add a new disk to the mounted btrfs we don't record it
as of now, disk add is a critical change of btrfs configuration,
it must be recorded in the syslog to help offline investigations
of customer problems when reported.
Signed-off-by: Anand Jain <Anand.Jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
---
v2: Accepts David's review comment, thanks
fs/btrfs/ioctl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 86d5474..4e10259 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2488,6 +2488,10 @@ static long btrfs_ioctl_add_dev(struct btrfs_root *root, void __user *arg)
vol_args->name[BTRFS_PATH_NAME_MAX] = '\0';
ret = btrfs_init_new_device(root, vol_args->name);
+ if (!ret)
+ btrfs_info(root->fs_info, "device added %s",
+ vol_args->name);
+
kfree(vol_args);
out:
mutex_unlock(&root->fs_info->volume_mutex);
--
2.0.0.257.g75cc6c6
next prev parent reply other threads:[~2014-07-02 1:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:58 [PATCH 1/2] btrfs: device add must be sysloged Anand Jain
2014-06-30 16:58 ` [PATCH 2/2] btrfs: device delete " Anand Jain
2014-07-01 17:49 ` David Sterba
2014-07-01 17:46 ` [PATCH 1/2] btrfs: device add " David Sterba
2014-07-02 1:39 ` Anand Jain
2014-07-02 1:37 ` Anand Jain [this message]
2014-07-02 1:37 ` [PATCH 2/2 v2] btrfs: device delete " Anand Jain
2014-07-02 7:03 ` Satoru Takeuchi
2014-07-02 7:02 ` [PATCH 1/2 v2] btrfs: device add " Satoru Takeuchi
2014-07-02 7:06 ` Satoru Takeuchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404265052-29424-1-git-send-email-Anand.Jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).