From: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: add mount status check for btrfs-image
Date: Fri, 4 Jul 2014 09:57:06 +0800 [thread overview]
Message-ID: <1404439026.22279.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20140703165818.GH1553@twin.jikos.cz>
On Thu, 2014-07-03 at 18:58 +0200, David Sterba wrote:
> On Thu, Jul 03, 2014 at 10:06:34AM +0800, Gui Hecheng wrote:
> > The btrfs-image tool should not be run on a mounted filesystem.
>
> Should not, but for some values of "sometimes" it makes sense, eg.
> capturing image of an otherwise quiescent filesystem, a read-only mount
> or after a crash.
Ah, read-only mount is really a case.
> This utility is used for debugging so I'd prefer to let the user do as
> he likes, though printing the warning about the mount status is a good
> improvement.
I agree, then I'll keep the check_mounted and just give a prompt and let
it continue.
> > The undergoing fs operations may change what you have imaged a while ago,
> > this makes the image meanmingless.
>
> I'm not familiar with the image format, but maybe we can set a bit in
> the header when the filesystem was not captured cleanly.
Hmm...This is a point, I think I'll give it a try in another patch.
next prev parent reply other threads:[~2014-07-04 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 2:06 [PATCH 1/2] btrfs-progs: add ask_user confirmation for btrfstune clear seeding flag Gui Hecheng
2014-07-03 2:06 ` [PATCH] btrfs-progs: add mount status check for btrfs-image Gui Hecheng
2014-07-03 16:58 ` David Sterba
2014-07-04 1:57 ` Gui Hecheng [this message]
2014-07-07 1:56 ` [PATCH v2] " Gui Hecheng
2014-07-03 2:06 ` [PATCH] btrfs-progs: prevent select invalid dev super after dev replace Gui Hecheng
2014-07-03 18:10 ` David Sterba
2014-07-04 1:09 ` Gui Hecheng
2014-07-03 2:06 ` [PATCH 2/2] btrfs-progs: update manpage with new option -y for btrfstune Gui Hecheng
2014-07-03 16:51 ` [PATCH 1/2] btrfs-progs: add ask_user confirmation for btrfstune clear seeding flag David Sterba
2014-07-04 1:59 ` Gui Hecheng
2014-07-04 13:05 ` David Sterba
2014-07-07 1:54 ` [PATCH v2] " Gui Hecheng
2014-07-07 1:54 ` [PATCH v2] btrfs-progs: update manpage with new option -f for btrfstune Gui Hecheng
2014-08-19 16:32 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404439026.22279.8.camel@localhost.localdomain \
--to=guihc.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).