From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root()
Date: Thu, 10 Jul 2014 11:05:10 +0800 [thread overview]
Message-ID: <1404961513-14614-1-git-send-email-quwenruo@cn.fujitsu.com> (raw)
When calling find_mount_root(), caller in fact wants to find the mount
point of *BTRFS*.
So also check ent->fstype in find_mount_root() and output proper error
messages if needed.
This will suppress a lot of "Inapproiate ioctl for device" error
message.
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
utils.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/utils.c b/utils.c
index 993d085..507ec6c 100644
--- a/utils.c
+++ b/utils.c
@@ -2412,6 +2412,7 @@ int find_mount_root(const char *path, char **mount_root)
struct mntent *ent;
int len;
int ret;
+ int not_btrfs;
int longest_matchlen = 0;
char *longest_match = NULL;
@@ -2432,6 +2433,10 @@ int find_mount_root(const char *path, char **mount_root)
free(longest_match);
longest_matchlen = len;
longest_match = strdup(ent->mnt_dir);
+ if (strcmp(ent->mnt_type, "btrfs"))
+ not_btrfs = 1;
+ else
+ not_btrfs = 0;
}
}
}
@@ -2443,6 +2448,12 @@ int find_mount_root(const char *path, char **mount_root)
path);
return -ENOENT;
}
+ if (not_btrfs) {
+ fprintf(stderr,
+ "ERROR: %s does not belong to a btrfs mount points.\n",
+ path);
+ return -EINVAL;
+ }
ret = 0;
*mount_root = realpath(longest_match, NULL);
--
2.0.1
next reply other threads:[~2014-07-10 3:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 3:05 Qu Wenruo [this message]
2014-07-10 3:05 ` [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root() Qu Wenruo
2014-07-10 7:33 ` Satoru Takeuchi
2014-07-10 8:10 ` Miao Xie
2014-07-10 8:26 ` Qu Wenruo
2014-07-10 23:24 ` Satoru Takeuchi
2014-07-10 3:05 ` [PATCH 3/4] btrfs-progs: Fix wrong indent in btrfs-progs Qu Wenruo
2014-07-10 7:34 ` Satoru Takeuchi
2014-07-29 12:02 ` David Sterba
2014-07-10 3:05 ` [PATCH v2 RESEND 4/4] btrfs-progs: Add mount point output for 'btrfs fi df' Qu Wenruo
2014-07-10 12:35 ` [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root() Martin Steigerwald
2014-07-22 19:15 ` David Sterba
2014-07-23 1:23 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404961513-14614-1-git-send-email-quwenruo@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).