From: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro
Date: Wed, 30 Jul 2014 09:17:36 +0800 [thread overview]
Message-ID: <1406683056.27474.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20140729121902.GP1553@twin.jikos.cz>
On Tue, 2014-07-29 at 14:19 +0200, David Sterba wrote:
> On Tue, Jul 29, 2014 at 02:16:14PM +0200, David Sterba wrote:
> > On Thu, Jul 17, 2014 at 10:40:38AM +0800, Gui Hecheng wrote:
> > > The raw number 36 for the uuid string length is somewhat confusing,
> > > use a macro to define replace it.
> >
> > There's the BTRFS_UUID_UNPARSED_SIZE macro, please use it instead to
> > avoid duplicate definitions.
>
> Or I'll do that myself as it's a really a small change.
Oh, yes, it is really kind of you to do so :)
next prev parent reply other threads:[~2014-07-30 1:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 2:40 [PATCH 1/4] btrfs-progs: adjust the return values for scrub Gui Hecheng
2014-07-17 2:40 ` [PATCH 2/4] btrfs-progs: remove unnecessary judgment for fd in scrub Gui Hecheng
2014-07-30 6:07 ` Satoru Takeuchi
2014-07-17 2:40 ` [PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro Gui Hecheng
2014-07-29 12:16 ` David Sterba
2014-07-29 12:19 ` David Sterba
2014-07-30 1:17 ` Gui Hecheng [this message]
2014-07-17 2:40 ` [PATCH 4/4] btrfs-progs: correct manpage option description for scrub Gui Hecheng
2014-07-30 5:20 ` Satoru Takeuchi
2014-07-30 5:39 ` Gui Hecheng
2014-07-30 6:09 ` Satoru Takeuchi
2014-07-30 7:32 ` [PATCH v2] " Gui Hecheng
2014-07-30 10:26 ` Duncan
2014-07-31 1:25 ` Gui Hecheng
2014-07-31 12:24 ` David Sterba
2014-07-30 6:03 ` [PATCH 1/4] btrfs-progs: adjust the return values " Satoru Takeuchi
2014-07-30 6:36 ` Satoru Takeuchi
2014-07-30 7:27 ` Gui Hecheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406683056.27474.1.camel@localhost.localdomain \
--to=guihc.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).