From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 5/8] btrfs: fix memory leak when there is no more seed device
Date: Wed, 13 Aug 2014 14:24:23 +0800 [thread overview]
Message-ID: <1407911066-5363-5-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1407911066-5363-1-git-send-email-anand.jain@oracle.com>
When we replace all the seed device in the system there is
no point in just keeping the btrfs_fs_devices with out
any device
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 6716658..314bbbf 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2013,6 +2013,8 @@ void btrfs_rm_dev_replace_srcdev(struct btrfs_fs_info *fs_info,
tmp_fs_devices = tmp_fs_devices->seed;
}
fs_devices->seed = NULL;
+ __btrfs_close_devices(fs_devices);
+ free_fs_devices(fs_devices);
}
}
--
2.0.0.153.g79dcccc
next prev parent reply other threads:[~2014-08-13 6:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 6:24 [PATCH 1/8] btrfs: preparatory to make btrfs_rm_dev_replace_srcdev() seed aware Anand Jain
2014-08-13 6:24 ` [PATCH 2/8] btrfs: replace seed device followed by unmount causes kernel WARNING Anand Jain
2014-08-19 15:44 ` David Sterba
2014-08-20 2:56 ` [PATCH 2/8 v2] " Anand Jain
2014-08-13 6:24 ` [PATCH 3/8] btrfs: fix rw_devices miss match after seed replace Anand Jain
2014-08-13 6:24 ` [PATCH 4/8 v2] btrfs: update sprout seed pointer when seed fs is relinquished Anand Jain
2014-08-13 6:24 ` Anand Jain [this message]
2014-08-13 6:24 ` [PATCH 6/8] btrfs: rw_devices shouldn't be incremented for seed fs in btrfs_rm_dev_replace_srcdev() Anand Jain
2014-08-13 6:24 ` [PATCH 7/8] btrfs: fix typo in the log message Anand Jain
2014-08-13 6:24 ` [PATCH 8/8] btrfs: rename total_bytes to avoid confusion Anand Jain
2014-08-19 15:37 ` David Sterba
2014-08-20 2:54 ` [PATCH 8/8 v2] " Anand Jain
2014-08-20 14:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407911066-5363-5-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).