From: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] btrfs-progs: remove meaningless debug info for restore
Date: Mon, 1 Sep 2014 09:35:09 +0800 [thread overview]
Message-ID: <1409535309.8843.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20140829144937.GE31801@twin.jikos.cz>
On Fri, 2014-08-29 at 16:49 +0200, David Sterba wrote:
> On Thu, Aug 28, 2014 at 10:25:55AM +0800, Gui Hecheng wrote:
> > The printf of @offset enlightens the user little.
> > And the restore cmd is not a debugging tool, so just
> > remove the debug-info-like printf.
>
> I'd like to let the restore command be more verbose as it's potentially
> working with a broken filesystem and getting details can help. There's
> -v option for increasing verbosity, please move the printf there.
OK，since the -v option seems to serve as a debug helper.
> Thaks.
next prev parent reply other threads:[~2014-09-01 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 2:25 [PATCH 1/3] btrfs-progs: fix len of read_extent_buffer for inline extent in restore Gui Hecheng
2014-08-28 2:25 ` [PATCH 2/3] btrfs-progs: fix next_leaf in restore as it improperly skips some slots Gui Hecheng
2014-08-28 2:25 ` [PATCH 3/3] btrfs-progs: remove meaningless debug info for restore Gui Hecheng
2014-08-29 14:49 ` David Sterba
2014-09-01 1:35 ` Gui Hecheng [this message]
2014-09-01 1:47 ` [PATCH] btrfs-progs: move debug info to verbose mode " Gui Hecheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409535309.8843.2.camel@localhost.localdomain \
--to=guihc.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).