* [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache
@ 2014-10-15 21:19 Josef Bacik
2014-10-16 9:18 ` David Sterba
2014-10-23 8:40 ` Miao Xie
0 siblings, 2 replies; 3+ messages in thread
From: Josef Bacik @ 2014-10-15 21:19 UTC (permalink / raw)
To: linux-btrfs
In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
unload, which makes us unable to unload and then re-load the btrfs module. This
fixes the problem. Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
fs/btrfs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index b83ef15..c1d020f 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2151,6 +2151,7 @@ static void __exit exit_btrfs_fs(void)
extent_map_exit();
extent_io_exit();
btrfs_interface_exit();
+ btrfs_end_io_wq_exit();
unregister_filesystem(&btrfs_fs_type);
btrfs_exit_sysfs();
btrfs_cleanup_fs_uuids();
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache
2014-10-15 21:19 [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache Josef Bacik
@ 2014-10-16 9:18 ` David Sterba
2014-10-23 8:40 ` Miao Xie
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2014-10-16 9:18 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-btrfs
On Wed, Oct 15, 2014 at 05:19:59PM -0400, Josef Bacik wrote:
> In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
> unload, which makes us unable to unload and then re-load the btrfs module. This
> fixes the problem. Thanks,
Oh crap, sorry.
Reviewed-by: David Sterba <dsterba@suse.cz>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache
2014-10-15 21:19 [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache Josef Bacik
2014-10-16 9:18 ` David Sterba
@ 2014-10-23 8:40 ` Miao Xie
1 sibling, 0 replies; 3+ messages in thread
From: Miao Xie @ 2014-10-23 8:40 UTC (permalink / raw)
To: Josef Bacik, linux-btrfs; +Cc: Chris Mason
On Wed, 15 Oct 2014 17:19:59 -0400, Josef Bacik wrote:
> In one of Dave's cleanup commits he forgot to call btrfs_end_io_wq_exit on
> unload, which makes us unable to unload and then re-load the btrfs module. This
> fixes the problem. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
> ---
> fs/btrfs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index b83ef15..c1d020f 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -2151,6 +2151,7 @@ static void __exit exit_btrfs_fs(void)
> extent_map_exit();
> extent_io_exit();
> btrfs_interface_exit();
> + btrfs_end_io_wq_exit();
> unregister_filesystem(&btrfs_fs_type);
> btrfs_exit_sysfs();
> btrfs_cleanup_fs_uuids();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-23 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 21:19 [PATCH] Btrfs: properly clean up btrfs_end_io_wq_cache Josef Bacik
2014-10-16 9:18 ` David Sterba
2014-10-23 8:40 ` Miao Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).