Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: <kreijack@inwind.it>
Cc: <dsterba@suse.cz>, Dimitri John Ledkov <xnox@debian.org>,
	cwillu <cwillu@cwillu.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	Zygo Blaxell <zblaxell@furryterror.org>
Subject: Re: [RFC][PATCH v2] mount.btrfs helper
Date: Fri, 5 Dec 2014 13:43:35 -0500	[thread overview]
Message-ID: <1417805015.4845.0@mail.thefacebook.com> (raw)
In-Reply-To: <5481F657.8090307@inwind.it>



On Fri, Dec 5, 2014 at 1:15 PM, Goffredo Baroncelli 
<kreijack@inwind.it> wrote:
> On 12/05/2014 05:41 PM, David Sterba wrote:
>>  We're looking
>>  for good reasons to justify the existence of the helper, but this is
>>  still not enough IMHO. I can see the convenience to do it 
>> automatically,
>>  but this assumes no udev available which is probably rare these 
>> days.
> 
> I have the following reasons to support a mount.btrfs helper:
> 1) it is in a good point to check that everything is ok (see the 
> thread
> related LVM snapshot, due to a dev.uuid conflicts),
> 2) it is in a good point to issue a good error explanation (missing
> device....)
> 3) it may handle case like "degraded" mode, where the filesystem is 
> not
> fully functional but even as degraded have "some" functionals..

Ok, these three things are worth improving, but I'd like to take a 
slightly different direction.  Instead of recreating chunks of btrfs 
dev scan, lets extend btrfs dev scan to at the very least understand #1 
and #2.  As much as possible we want to be leveraging the data in udev 
instead of recreating that functionality.

#3 is a slightly different feature, but we can have an extended btrfs 
dev scan or show explain the state of the filesystem to you.

 From there if we really need a mount helper, it can either use a 
libbtrfs to hit the scan code or be a bash script.

Thanks for trying to smooth our or wrinkles in this area.  It's 
definitely worth working on, I just want to make sure we recreate as 
little infrastructure as possible ;)

-chris




  reply	other threads:[~2014-12-05 18:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 17:43 [RFC][PATCH v2] mount.btrfs helper Goffredo Baroncelli
2014-11-30 22:11 ` Dimitri John Ledkov
2014-11-30 22:31   ` cwillu
2014-11-30 22:57     ` Dimitri John Ledkov
2014-11-30 23:27       ` cwillu
2014-12-05 15:32       ` Chris Mason
2014-12-05 16:01         ` Dimitri John Ledkov
2014-12-05 16:41           ` David Sterba
2014-12-05 18:15             ` Goffredo Baroncelli
2014-12-05 18:43               ` Chris Mason [this message]
2014-12-05 19:51                 ` Goffredo Baroncelli
2014-12-09 12:16                   ` David Sterba
2014-12-09 10:55                 ` David Sterba
2014-12-09 10:35           ` David Sterba
2014-12-04  2:09 ` Anand Jain
2014-12-04 17:58   ` Goffredo Baroncelli
2014-12-05  3:16     ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417805015.4845.0@mail.thefacebook.com \
    --to=clm@fb.com \
    --cc=cwillu@cwillu.com \
    --cc=dsterba@suse.cz \
    --cc=kreijack@inwind.it \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xnox@debian.org \
    --cc=zblaxell@furryterror.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox