From: Chris Mason <clm@fb.com>
To: Marc MERLIN <marc@merlins.org>
Cc: Roman Mamedov <rm@romanrm.net>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: 3.16.3: fs/btrfs/delayed-inode.c:1410 btrfs_assert_delayed_root_empty
Date: Mon, 29 Dec 2014 10:17:00 -0500 [thread overview]
Message-ID: <1419866220.13012.18@mail.thefacebook.com> (raw)
In-Reply-To: <20141228213606.GP17254@merlins.org>
On Sun, Dec 28, 2014 at 4:36 PM, Marc MERLIN <marc@merlins.org> wrote:
> On Mon, Dec 29, 2014 at 01:00:47AM +0500, Roman Mamedov wrote:
>> > Will btrfs scrub, even if it takes about 24H to run for me, tell
>> me
>> > which FS is affected and if so do I run btrfs repair?
>>
>> I had this:
>> https://urldefense.proofpoint.com/v1/url?u=http://www.spinics.net/lists/linux-btrfs/msg40586.html&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=6%2FL0lzzDhu0Y1hL9xm%2BQyA%3D%3D%0A&m=yBJylKLQ0wXzMPYXMMCJaXZfTMrX%2FbRGSoF3t%2FRZsUU%3D%0A&s=9d08d8fb169b6429b819fb9a0c2fda816b4b6c031ee4c5e6ca5a53bb04e3c067
>>
>> 1) I determined which btrfs of the multiple ones that I have is the
>> culprit, by
>> unmounting them one by one and seeing if the dmesg spam disappears;
>
> And of course it's the root filesystem on a remote server which I
> can't
> service remotely :-/
>
>> 3) After that, I ran btrfsck (it did found some errors that looked
>> like this,
>> repeated dozens of times, with different "root nnnnn" numbers):
>
> For the archives, one should use btrfs check --repair directly,
> btrfsck is
> dead.
>
>> 6) Surprisingly(#2), despite apparently not all of the errors
>> having been
>> fixed, the btrfs_assert_delayed_root_empty messages no longer
>> appear in dmesg.
>>
>> The current versions of files mentioned (xfce4-panel.xml and parts
>> of the Chromium profile)
>> were of course corrupted, but I already noticed that and restored
>> them from an earlier snapshot
>> even before starting the fsck (yes I also had backups, but didn't
>> need them as snapshotted versions
>> were fine).
>
> Thanks for the info. I think for now I'll be forced to leave the
> broken
> FS run as is and will deal with it when I get home.
>
> Dear btrfs-devs: this is one more example of btrfs having a problem
> with
> a non consistent state that ended up on disk.
>
> I got there this way:
> - btrfs on top of dmcrypt on top of md raid1 (sorry too many raid bugs
> in btrfs, so I went back to mdadm at the time)
> - kernel bug in a serial driver was causing a loop, so I was forced to
> cycle power remotely
> - btrfs got broken as per this mail.
> - please please please, all warnings and bugs should still be fixed to
> output what device they happened on. Making the admin guess by
> trying
> filesystem one by one isn't really a good way.
>
> Anyway, assuming there isn't a core bug in the btrfs "always
> consistent
> state on disk" code, dmcrypt or mdadm prevented a consistent state
> from
> reaching the disks.
>
> Separately, I wish I could just fix this while the filesystem is
> online.
> btrfs scrub ran totally clean with no errors :(
> scrub device /dev/mapper/cryptroot (id 1) done
> scrub started at Sun Dec 28 12:07:55 2014 and finished after
> 512 seconds
> total bytes scrubbed: 25.95GiB with 0 errors
>
> Thankfully the filesystem is still running for now, so it could be
> worse.
I've hit this recently on my laptop, and haven't yet been able to
recreate it on a machine where I can debug things. The messages are an
error in the log tree replay code, and I don't think they are actually
related to any corruptions. Trying to nail it down today.
-chris
next prev parent reply other threads:[~2014-12-29 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 19:26 3.16.3: fs/btrfs/delayed-inode.c:1410 btrfs_assert_delayed_root_empty Marc MERLIN
2014-12-28 20:00 ` Roman Mamedov
2014-12-28 21:36 ` Marc MERLIN
2014-12-29 15:17 ` Chris Mason [this message]
2014-12-29 15:41 ` Marc MERLIN
2014-12-29 15:57 ` Chris Mason
2014-12-30 1:06 ` Qu Wenruo
2014-12-31 18:30 ` [PATCH] Btrfs: don't delay inode ref updates during log replay Chris Mason
2015-01-01 22:58 ` Marc MERLIN
2015-01-02 0:44 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419866220.13012.18@mail.thefacebook.com \
--to=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marc@merlins.org \
--cc=rm@romanrm.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).