From: Chris Mason <clm@fb.com>
To: <dsterba@suse.cz>
Cc: Arnd Bergmann <arnd@arndb.de>, Miao Xie <miaox@cn.fujitsu.com>,
Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.cz>,
<linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: avoid build warning on 32-bit
Date: Tue, 13 Jan 2015 20:12:04 -0500 [thread overview]
Message-ID: <1421197924.21014.17@mail.thefacebook.com> (raw)
In-Reply-To: <20150114001606.GQ3685@twin.jikos.cz>
On Tue, Jan 13, 2015 at 7:16 PM, David Sterba <dsterba@suse.cz> wrote:
> On Tue, Jan 13, 2015 at 03:09:03PM +0100, Arnd Bergmann wrote:
>> A recent change introduced a type cast from a private 64-bit
>> value to a pointer, which works fine on 64-bit architectures,
>> but not on 32-bit ones, where it produces a harmless compiler
>> warning:
>>
>> fs/btrfs/extent_io.c: In function 'btrfs_free_io_failure_record':
>> fs/btrfs/extent_io.c:2193:13: warning: cast to pointer from integer
>> of different size [-Wint-to-pointer-cast]
>>
>> This adds an intermediate cast to 'unsigned long', which tells
>> the compiler to ignore the type mismatch.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: f612496bca664 ("Btrfs: cleanup the read failure record after
>> write
>> or when the inode is freeing")
>
> Already reported, but not merged
I'll take the original cast one for now and we can do the larger
cleanup for the next merge window.
-chris
prev parent reply other threads:[~2015-01-14 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:09 [PATCH] Btrfs: avoid build warning on 32-bit Arnd Bergmann
2015-01-14 0:16 ` David Sterba
2015-01-14 1:12 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421197924.21014.17@mail.thefacebook.com \
--to=clm@fb.com \
--cc=arnd@arndb.de \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).