* [PATCH] Btrfs: fix typo of variable in scrub_stripe
@ 2015-01-09 8:37 Tsutomu Itoh
2015-01-09 8:44 ` Miao Xie
2015-01-16 10:51 ` David Sterba
0 siblings, 2 replies; 4+ messages in thread
From: Tsutomu Itoh @ 2015-01-09 8:37 UTC (permalink / raw)
To: linux-btrfs
The address that should be freed is not 'ppath' but 'path'.
Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
---
fs/btrfs/scrub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index f2bb13a..403fbdb 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -3053,7 +3053,7 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
ppath = btrfs_alloc_path();
if (!ppath) {
- btrfs_free_path(ppath);
+ btrfs_free_path(path);
return -ENOMEM;
}
--
2.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Btrfs: fix typo of variable in scrub_stripe
2015-01-09 8:37 [PATCH] Btrfs: fix typo of variable in scrub_stripe Tsutomu Itoh
@ 2015-01-09 8:44 ` Miao Xie
2015-01-16 10:51 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: Miao Xie @ 2015-01-09 8:44 UTC (permalink / raw)
To: Tsutomu Itoh, linux-btrfs
On Fri, 09 Jan 2015 17:37:52 +0900, Tsutomu Itoh wrote:
> The address that should be freed is not 'ppath' but 'path'.
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> ---
> fs/btrfs/scrub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index f2bb13a..403fbdb 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -3053,7 +3053,7 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
>
> ppath = btrfs_alloc_path();
> if (!ppath) {
> - btrfs_free_path(ppath);
> + btrfs_free_path(path);
My bad. Thanks to fix it.
Reviewed-by: Miao Xie <miaoxie@huawei.com>
> return -ENOMEM;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Btrfs: fix typo of variable in scrub_stripe
2015-01-09 8:37 [PATCH] Btrfs: fix typo of variable in scrub_stripe Tsutomu Itoh
2015-01-09 8:44 ` Miao Xie
@ 2015-01-16 10:51 ` David Sterba
2015-01-16 13:27 ` Chris Mason
1 sibling, 1 reply; 4+ messages in thread
From: David Sterba @ 2015-01-16 10:51 UTC (permalink / raw)
To: clm; +Cc: Tsutomu Itoh, linux-btrfs
On Fri, Jan 09, 2015 at 05:37:52PM +0900, Tsutomu Itoh wrote:
> The address that should be freed is not 'ppath' but 'path'.
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Chris, please add this patch to the next 3.19-rc, the code has been
introduced during this merge window.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Btrfs: fix typo of variable in scrub_stripe
2015-01-16 10:51 ` David Sterba
@ 2015-01-16 13:27 ` Chris Mason
0 siblings, 0 replies; 4+ messages in thread
From: Chris Mason @ 2015-01-16 13:27 UTC (permalink / raw)
To: dsterba; +Cc: Tsutomu Itoh, linux-btrfs
On Fri, Jan 16, 2015 at 5:51 AM, David Sterba <dsterba@suse.cz> wrote:
> On Fri, Jan 09, 2015 at 05:37:52PM +0900, Tsutomu Itoh wrote:
>> The address that should be freed is not 'ppath' but 'path'.
>>
>> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
>
> Chris, please add this patch to the next 3.19-rc, the code has been
> introduced during this merge window.
Yes, I've got it queued up here, along with Filipe's v2 from today and
a few others.
-chris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-16 13:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-09 8:37 [PATCH] Btrfs: fix typo of variable in scrub_stripe Tsutomu Itoh
2015-01-09 8:44 ` Miao Xie
2015-01-16 10:51 ` David Sterba
2015-01-16 13:27 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).