Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: <dsterba@suse.cz>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
	Zhao Lei <zhaolei@cn.fujitsu.com>
Subject: Re: [PATCH] Btrfs: fix allocation size calculations in alloc_btrfs_bio
Date: Fri, 20 Feb 2015 09:37:32 -0500	[thread overview]
Message-ID: <1424443052.23448.0@mail.thefacebook.com> (raw)
In-Reply-To: <20150220143526.GS8720@suse.cz>

On Fri, Feb 20, 2015 at 9:35 AM, David Sterba <dsterba@suse.cz> wrote:
> On Thu, Feb 19, 2015 at 08:59:30PM -0500, Chris Mason wrote:
>>  Since commit 8e5cfb55d3f (Btrfs: Make raid_map array be inlined in
>>  btrfs_bio structure), the raid map array is allocated along with the
>>  btrfs bio in alloc_btrfs_bio.  The calculation used to decide how 
>> much
>>  we need to allocate was using the wrong parameter passed into the
>>  allocation function.
>> 
>>  The passed in real_stripes will be zero if a target replace 
>> operation
>>  is not currently running.  We want to use total_stripes instead.
>> 
>>  Signed-off-by: Chris Mason <clm@fb.com>
>>  Reported-by: Dave Sterba <dsterba@suse.cz>
> 
> Tested-by: David Sterba <dsterba@suse.cz>
> 
> Current master + this patch with full slub_debug is now ok with
> btrfs/023.

Thanks Dave.  It also survived all night with raid6 and stress.sh.  I'm 
sending to Linus today.

-chris




  reply	other threads:[~2015-02-20 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  1:59 [PATCH] Btrfs: fix allocation size calculations in alloc_btrfs_bio Chris Mason
2015-02-20 14:35 ` David Sterba
2015-02-20 14:37   ` Chris Mason [this message]
2015-02-23  1:33 ` Zhao Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424443052.23448.0@mail.thefacebook.com \
    --to=clm@fb.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox