* [PATCH V2] btrfs: Print Warning only if ENOSPC_DEBUG is enabled
@ 2015-11-02 21:55 Ashish Samant
2016-03-11 15:49 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Ashish Samant @ 2015-11-02 21:55 UTC (permalink / raw)
To: linux-btrfs; +Cc: ashish.samant
Dont call WARN_ON for ENOSPC error unless ENOSPC_DEBUG is enabled.
Signed-off-by : Ashish Samant <ashish.samant@oracle.com>
---
fs/btrfs/delayed-inode.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index a2ae427..b86cfd9 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -652,9 +652,13 @@ static int btrfs_delayed_inode_reserve_metadata(
goto out;
ret = btrfs_block_rsv_migrate(src_rsv, dst_rsv, num_bytes);
- if (!WARN_ON(ret))
+ if (!ret)
goto out;
+ if (btrfs_test_opt(root, ENOSPC_DEBUG))
+ WARN(1, KERN_DEBUG
+ "btrfs: block rsv migrate returned %d\n", ret);
+
/*
* Ok this is a problem, let's just steal from the global rsv
* since this really shouldn't happen that often.
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] btrfs: Print Warning only if ENOSPC_DEBUG is enabled
2015-11-02 21:55 [PATCH V2] btrfs: Print Warning only if ENOSPC_DEBUG is enabled Ashish Samant
@ 2016-03-11 15:49 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-03-11 15:49 UTC (permalink / raw)
To: Ashish Samant; +Cc: linux-btrfs
On Mon, Nov 02, 2015 at 01:55:10PM -0800, Ashish Samant wrote:
> Dont call WARN_ON for ENOSPC error unless ENOSPC_DEBUG is enabled.
>
> Signed-off-by : Ashish Samant <ashish.samant@oracle.com>
> ---
> fs/btrfs/delayed-inode.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index a2ae427..b86cfd9 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -652,9 +652,13 @@ static int btrfs_delayed_inode_reserve_metadata(
> goto out;
>
> ret = btrfs_block_rsv_migrate(src_rsv, dst_rsv, num_bytes);
> - if (!WARN_ON(ret))
> + if (!ret)
> goto out;
>
> + if (btrfs_test_opt(root, ENOSPC_DEBUG))
> + WARN(1, KERN_DEBUG
> + "btrfs: block rsv migrate returned %d\n", ret);
Please use btrfs_debug
> +
> /*
> * Ok this is a problem, let's just steal from the global rsv
> * since this really shouldn't happen that often.
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-02 21:55 [PATCH V2] btrfs: Print Warning only if ENOSPC_DEBUG is enabled Ashish Samant
2016-03-11 15:49 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).