From: Christoph Anton Mitterer <calestyo@scientia.net>
To: dsterba@suse.cz, Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: fsck: Fix a false alert where extent record has wrong metadata flag
Date: Thu, 26 Nov 2015 16:20:21 +0100 [thread overview]
Message-ID: <1448551221.8809.7.camel@scientia.net> (raw)
In-Reply-To: <20151126142733.GR31035@twin.jikos.cz>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
Hey.
I can confirm that the new patch fixes the issue on both test
filesystems.
Thanks for working that out. I guess there's no longer a need to keep
that old filesystems now?!
Cheers,
Chris.
On Thu, 2015-11-26 at 15:27 +0100, David Sterba wrote:
> On Wed, Nov 25, 2015 at 02:19:06PM +0800, Qu Wenruo wrote:
> > In process_extent_item(), it gives 'metadata' initial value 0, but
> > for
> > non-skinny-metadata case, metadata extent can't be judged just from
> > key
> > type and it forgot that case.
> >
> > This causes a lot of false alert in non-skinny-metadata filesystem.
> >
> > Fix it by set correct metadata value before calling
> > add_extent_rec().
> >
> > Reported-by: Christoph Anton Mitterer <calestyo@scientia.net>
> > Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
>
> Patch replaced, thanks. The test image is pushed as well.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5313 bytes --]
next prev parent reply other threads:[~2015-11-26 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 6:19 [PATCH v2] btrfs-progs: fsck: Fix a false alert where extent record has wrong metadata flag Qu Wenruo
2015-11-26 14:27 ` David Sterba
2015-11-26 15:20 ` Christoph Anton Mitterer [this message]
2015-11-27 0:40 ` Qu Wenruo
2015-11-27 0:54 ` Christoph Anton Mitterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448551221.8809.7.camel@scientia.net \
--to=calestyo@scientia.net \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox