From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2910C47254 for ; Tue, 5 May 2020 11:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1ECD206A4 for ; Tue, 5 May 2020 11:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbgEEL4u convert rfc822-to-8bit (ORCPT ); Tue, 5 May 2020 07:56:50 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:34666 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727931AbgEEL4t (ORCPT ); Tue, 5 May 2020 07:56:49 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0C0376075EB6; Tue, 5 May 2020 13:56:47 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6a91-kHTbc-Q; Tue, 5 May 2020 13:56:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 02A7760CEF4B; Tue, 5 May 2020 13:56:46 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KlCIGRGSqhZO; Tue, 5 May 2020 13:56:45 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id C496B60CEF2B; Tue, 5 May 2020 13:56:45 +0200 (CEST) Date: Tue, 5 May 2020 13:56:45 +0200 (CEST) From: Richard Weinberger To: Johannes Thumshirn Cc: Eric Biggers , Johannes Thumshirn , David Sterba , linux-fsdevel , linux-btrfs , david , Sascha Hauer Message-ID: <1450548725.186388.1588679805599.JavaMail.zimbra@nod.at> In-Reply-To: References: <20200428105859.4719-1-jth@kernel.org> <20200428105859.4719-2-jth@kernel.org> <20200501053908.GC1003@sol.localdomain> <769963893.184242.1588628271082.JavaMail.zimbra@nod.at> Subject: Re: [PATCH v2 1/2] btrfs: add authentication support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809) Thread-Topic: btrfs: add authentication support Thread-Index: AQHWHUw3Fjk34p8J2kWvUrIfOj4HzXkTZJtq Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Johannes Thumshirn" > An: "richard" > CC: "Eric Biggers" , "Johannes Thumshirn" , "David Sterba" , > "linux-fsdevel" , "linux-btrfs" , "david" > , "Sascha Hauer" > Gesendet: Dienstag, 5. Mai 2020 09:46:42 > Betreff: Re: [PATCH v2 1/2] btrfs: add authentication support > On 04/05/2020 23:41, Richard Weinberger wrote: >> Well, UBIFS stores auth_hash_name on disk but does not trust it. >> It is always required to provide auth_hash_name as mount parameter. >> At mount time it is compared to the stored name (among with other parameters) >> to detect misconfigurations. > > OK, thanks for the information. > > Will do so as well in v3 With UBIFS this is now the second in-tree filesystem with authentication support. IMHO it is worth adding a new statx flag to denote this. Just like we do already for encrypted and verity protected files. STATX_ATTR_AUTHED? Especially for BTRFS user this is valubale information since BTRFS authentication is incompatible with nodatacow'ed files/dirs/subvolumes. And it might be not obvious which files are protected and which are not. Thanks, //richard