linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mchristi@redhat.com
To: linux-f2fs-devel@lists.sourceforge.net,
	linux-ext4@vger.kernel.org, konrad.wilk@oracle.com,
	drbd-dev@lists.linbit.com, philipp.reisner@linbit.com,
	lars.ellenberg@linbit.com, linux-raid@vger.kernel.org,
	dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-mtd@lists.infradead.org, target-devel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, osd-dev@open-osd.org,
	xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com
Cc: Mike Christie <mchristi@redhat.com>
Subject: [PATCH 13/35] xfs: set bi_op to REQ_OP
Date: Mon, 11 Jan 2016 14:21:11 -0600	[thread overview]
Message-ID: <1452543693-4440-14-git-send-email-mchristi@redhat.com> (raw)
In-Reply-To: <1452543693-4440-1-git-send-email-mchristi@redhat.com>

From: Mike Christie <mchristi@redhat.com>

This patch has xfs set the bio bi_op to a REQ_OP, and
rq_flag_bits to bi_rw.

Signed-off-by: Mike Christie <mchristi@redhat.com>
---
 fs/xfs/xfs_aops.c |  3 ++-
 fs/xfs/xfs_buf.c  | 27 +++++++++++++++------------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 5525a1b..25673e0 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -382,7 +382,8 @@ xfs_submit_ioend_bio(
 	atomic_inc(&ioend->io_remaining);
 	bio->bi_private = ioend;
 	bio->bi_end_io = xfs_end_bio;
-	bio->bi_rw = (wbc->sync_mode == WB_SYNC_ALL ? WRITE_SYNC : WRITE);
+	bio->bi_op = REQ_OP_WRITE;
+	bio->bi_rw = WB_SYNC_ALL ? WRITE_SYNC : 0;
 	submit_bio(bio);
 }
 
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 9fd85d5..de35a3c 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1124,7 +1124,8 @@ xfs_buf_ioapply_map(
 	int		map,
 	int		*buf_offset,
 	int		*count,
-	int		rw)
+	int		op,
+	int		op_flags)
 {
 	int		page_index;
 	int		total_nr_pages = bp->b_page_count;
@@ -1163,7 +1164,8 @@ next_chunk:
 	bio->bi_iter.bi_sector = sector;
 	bio->bi_end_io = xfs_buf_bio_end_io;
 	bio->bi_private = bp;
-	bio->bi_rw = rw;
+	bio->bi_op = op;
+	bio->bi_rw = op_flags;
 
 	for (; size && nr_pages; nr_pages--, page_index++) {
 		int	rbytes, nbytes = PAGE_SIZE - offset;
@@ -1207,7 +1209,8 @@ _xfs_buf_ioapply(
 	struct xfs_buf	*bp)
 {
 	struct blk_plug	plug;
-	int		rw;
+	int		op;
+	int		op_flags = 0;
 	int		offset;
 	int		size;
 	int		i;
@@ -1226,14 +1229,13 @@ _xfs_buf_ioapply(
 		bp->b_ioend_wq = bp->b_target->bt_mount->m_buf_workqueue;
 
 	if (bp->b_flags & XBF_WRITE) {
+		op = REQ_OP_WRITE;
 		if (bp->b_flags & XBF_SYNCIO)
-			rw = WRITE_SYNC;
-		else
-			rw = WRITE;
+			op_flags = WRITE_SYNC;
 		if (bp->b_flags & XBF_FUA)
-			rw |= REQ_FUA;
+			op_flags |= REQ_FUA;
 		if (bp->b_flags & XBF_FLUSH)
-			rw |= REQ_FLUSH;
+			op_flags |= REQ_FLUSH;
 
 		/*
 		 * Run the write verifier callback function if it exists. If
@@ -1263,13 +1265,14 @@ _xfs_buf_ioapply(
 			}
 		}
 	} else if (bp->b_flags & XBF_READ_AHEAD) {
-		rw = READA;
+		op = REQ_OP_READ;
+		op_flags = REQ_RAHEAD;
 	} else {
-		rw = READ;
+		op = REQ_OP_READ;
 	}
 
 	/* we only use the buffer cache for meta-data */
-	rw |= REQ_META;
+	op_flags |= REQ_META;
 
 	/*
 	 * Walk all the vectors issuing IO on them. Set up the initial offset
@@ -1281,7 +1284,7 @@ _xfs_buf_ioapply(
 	size = BBTOB(bp->b_io_length);
 	blk_start_plug(&plug);
 	for (i = 0; i < bp->b_map_count; i++) {
-		xfs_buf_ioapply_map(bp, i, &offset, &size, rw);
+		xfs_buf_ioapply_map(bp, i, &offset, &size, op, op_flags);
 		if (bp->b_error)
 			break;
 		if (size <= 0)
-- 
1.8.3.1


  parent reply	other threads:[~2016-01-11 20:22 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 20:20 [PATCH 00/35 v3] eparate operations from flags in the bio/request structs mchristi
2016-01-11 20:20 ` [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio mchristi
2016-01-11 20:21 ` [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields mchristi
2016-01-11 20:21 ` [PATCH 03/35] block, fs, mm, drivers: set bi_op to REQ_OP mchristi
2016-01-11 20:21 ` [PATCH 04/35] fs: have submit_bh users pass in op and flags separately mchristi
2016-01-11 20:21 ` [PATCH 05/35] fs: have ll_rw_block " mchristi
2016-01-11 20:21 ` [PATCH 06/35] direct-io: set bi_op to REQ_OP mchristi
2016-01-11 20:21 ` [PATCH 07/35] btrfs: have submit_one_bio users setup bio bi_op mchristi
2016-01-11 20:21 ` [PATCH 08/35] btrfs: set bi_op tp REQ_OP mchristi
2016-01-11 20:21 ` [PATCH 09/35] btrfs: update __btrfs_map_block for bi_op transition mchristi
2016-01-11 20:21 ` [PATCH 10/35] btrfs: don't pass rq_flag_bits if there is a bio mchristi
2016-01-11 20:21 ` [PATCH 11/35] f2fs: set bi_op to REQ_OP mchristi
2016-01-11 20:21 ` [PATCH 12/35] gfs2: " mchristi
2016-01-11 20:21 ` mchristi [this message]
2016-01-11 20:21 ` [PATCH 14/35] hfsplus: " mchristi
2016-01-11 20:21 ` [PATCH 15/35] mpage: " mchristi
2016-01-11 20:21 ` [PATCH 16/35] nilfs: " mchristi
2016-01-11 20:21 ` [PATCH 17/35] ocfs2: " mchristi
2016-01-11 20:21 ` [PATCH 18/35] pm: " mchristi
2016-01-11 20:21 ` [PATCH 19/35] dm: " mchristi
2016-01-11 20:21 ` [PATCH 20/35] dm: pass dm stats data dir instead of bi_rw mchristi
2016-01-11 20:21 ` [PATCH 21/35] bcache: set bi_op to REQ_OP mchristi
2016-01-11 20:21 ` [PATCH 22/35] drbd: " mchristi
2016-01-11 20:21 ` [PATCH 23/35] md/raid: " mchristi
2016-01-11 20:21 ` [PATCH 24/35] xen: " mchristi
2016-01-11 20:21 ` [PATCH 25/35] target: " mchristi
2016-01-11 20:21 ` [PATCH 26/35] block: set op " mchristi
2016-01-11 20:21 ` [PATCH 27/35] drivers: set request " mchristi
2016-01-11 20:21 ` [PATCH 28/35] blktrace: get op from req->op/bio->bi_op mchristi
2016-01-11 20:21 ` [PATCH 29/35] ide cd: do not set REQ_WRITE on requests mchristi
2016-01-11 20:21 ` [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs mchristi
2016-01-11 20:21 ` [PATCH 31/35] block, fs: remove old REQ definitions mchristi
2016-01-11 20:21 ` [PATCH 32/35] block: shrink bi_rw and bi_op mchristi
2016-01-11 20:21 ` [PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation mchristi
2016-01-11 20:21 ` [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua mchristi
2016-01-11 20:21 ` [PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH mchristi
2016-01-18 18:15 ` [PATCH 00/35 v3] eparate operations from flags in the bio/request structs Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2016-02-24 19:47 [PATCH 00/35 v4] separate " mchristi
2016-02-24 19:47 ` [PATCH 13/35] xfs: set bi_op to REQ_OP mchristi
2016-01-05 20:53 [PATCH 00/35 v2] separate operations from flags in the bio/request structs mchristi
2016-01-05 20:53 ` [PATCH 13/35] xfs: set bi_op to REQ_OP mchristi
2016-01-07  3:11   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452543693-4440-14-git-send-email-mchristi@redhat.com \
    --to=mchristi@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=konrad.wilk@oracle.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=osd-dev@open-osd.org \
    --cc=philipp.reisner@linbit.com \
    --cc=target-devel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).