From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: linux-btrfs@vger.kernel.org
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
jbacik@fb.com, clm@fb.com, bo.li.liu@oracle.com, dsterba@suse.cz,
chandan@mykolab.com
Subject: [PATCH V10 11/12] Btrfs: Clean pte corresponding to page straddling i_size
Date: Thu, 21 Jan 2016 15:56:03 +0530 [thread overview]
Message-ID: <1453371964-4917-12-git-send-email-chandan@linux.vnet.ibm.com> (raw)
In-Reply-To: <1453371964-4917-1-git-send-email-chandan@linux.vnet.ibm.com>
When extending a file by either "truncate up" or by writing beyond i_size, the
page which had i_size needs to be marked "read only" so that future writes to
the page via mmap interface causes btrfs_page_mkwrite() to be invoked. If not,
a write performed after extending the file via the mmap interface will find
the page to be writaeable and continue writing to the page without invoking
btrfs_page_mkwrite() i.e. we end up writing to a file without reserving disk
space.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
fs/btrfs/file.c | 12 ++++++++++--
fs/btrfs/inode.c | 2 +-
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 9682002..703d597 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1780,6 +1780,8 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb,
ssize_t err;
loff_t pos;
size_t count;
+ loff_t oldsize;
+ int clean_page = 0;
mutex_lock(&inode->i_mutex);
err = generic_write_checks(iocb, from);
@@ -1818,14 +1820,17 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb,
pos = iocb->ki_pos;
count = iov_iter_count(from);
start_pos = round_down(pos, root->sectorsize);
- if (start_pos > i_size_read(inode)) {
+ oldsize = i_size_read(inode);
+ if (start_pos > oldsize) {
/* Expand hole size to cover write data, preventing empty gap */
end_pos = round_up(pos + count, root->sectorsize);
- err = btrfs_cont_expand(inode, i_size_read(inode), end_pos);
+ err = btrfs_cont_expand(inode, oldsize, end_pos);
if (err) {
mutex_unlock(&inode->i_mutex);
goto out;
}
+ if (start_pos > round_up(oldsize, root->sectorsize))
+ clean_page = 1;
}
if (sync)
@@ -1837,6 +1842,9 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb,
num_written = __btrfs_buffered_write(file, from, pos);
if (num_written > 0)
iocb->ki_pos = pos + num_written;
+ if (clean_page)
+ pagecache_isize_extended(inode, oldsize,
+ i_size_read(inode));
}
mutex_unlock(&inode->i_mutex);
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 442b184..364eaf9 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4930,7 +4930,6 @@ static int btrfs_setsize(struct inode *inode, struct iattr *attr)
}
if (newsize > oldsize) {
- truncate_pagecache(inode, newsize);
/*
* Don't do an expanding truncate while snapshoting is ongoing.
* This is to ensure the snapshot captures a fully consistent
@@ -4953,6 +4952,7 @@ static int btrfs_setsize(struct inode *inode, struct iattr *attr)
i_size_write(inode, newsize);
btrfs_ordered_update_i_size(inode, i_size_read(inode), NULL);
+ pagecache_isize_extended(inode, oldsize, newsize);
ret = btrfs_update_inode(trans, root, inode);
btrfs_end_write_no_snapshoting(root);
btrfs_end_transaction(trans, root);
--
2.1.0
next prev parent reply other threads:[~2016-01-21 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 10:25 [PATCH V10 00/12] Btrfs: Pre subpagesize-blocksize cleanups Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 01/12] Btrfs: __btrfs_buffered_write: Reserve/release extents aligned to block size Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 02/12] Btrfs: Compute and look up csums based on sectorsized blocks Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 03/12] Btrfs: Direct I/O read: Work " Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 04/12] Btrfs: fallocate: Work with " Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 05/12] Btrfs: btrfs_page_mkwrite: Reserve space in sectorsized units Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 06/12] Btrfs: Search for all ordered extents that could span across a page Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 07/12] Btrfs: Use (eb->start, seq) as search key for tree modification log Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 08/12] Btrfs: btrfs_submit_direct_hook: Handle map_length < bio vector length Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 09/12] Btrfs: Limit inline extents to root->sectorsize Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 10/12] Btrfs: Fix block size returned to user space Chandan Rajendra
2016-01-21 10:26 ` Chandan Rajendra [this message]
2016-01-21 10:26 ` [PATCH V10 12/12] Btrfs: btrfs_ioctl_clone: Truncate complete page after performing clone operation Chandan Rajendra
2016-01-29 13:30 ` [PATCH V10 00/12] Btrfs: Pre subpagesize-blocksize cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453371964-4917-12-git-send-email-chandan@linux.vnet.ibm.com \
--to=chandan@linux.vnet.ibm.com \
--cc=bo.li.liu@oracle.com \
--cc=chandan@mykolab.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).