From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: linux-btrfs@vger.kernel.org
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
jbacik@fb.com, clm@fb.com, bo.li.liu@oracle.com, dsterba@suse.cz,
chandan@mykolab.com
Subject: [PATCH V10 12/12] Btrfs: btrfs_ioctl_clone: Truncate complete page after performing clone operation
Date: Thu, 21 Jan 2016 15:56:04 +0530 [thread overview]
Message-ID: <1453371964-4917-13-git-send-email-chandan@linux.vnet.ibm.com> (raw)
In-Reply-To: <1453371964-4917-1-git-send-email-chandan@linux.vnet.ibm.com>
In subpagesize-blocksize scenario, the "destination offset" argument passed to
the btrfs_ioctl_clone() can be aligned to sectorsize but may not be
necessarily aligned to the machine's page size. In such cases,
truncate_inode_pages_range() ends up zeroing out the partial page and future
read operations will return incorrect data. Hence this commit explicitly
rounds down the "destination offset" to the machine's page size.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
fs/btrfs/ioctl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 8bbecda..4e11059 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -3914,8 +3914,9 @@ static noinline long btrfs_ioctl_clone(struct file *file, unsigned long srcfd,
* Truncate page cache pages so that future reads will see the cloned
* data immediately and not the previous data.
*/
- truncate_inode_pages_range(&inode->i_data, destoff,
- PAGE_CACHE_ALIGN(destoff + len) - 1);
+ truncate_inode_pages_range(&inode->i_data,
+ round_down(destoff, PAGE_CACHE_SIZE),
+ round_up(destoff + len, PAGE_CACHE_SIZE) - 1);
out_unlock:
if (!same_inode)
btrfs_double_inode_unlock(src, inode);
--
2.1.0
next prev parent reply other threads:[~2016-01-21 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 10:25 [PATCH V10 00/12] Btrfs: Pre subpagesize-blocksize cleanups Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 01/12] Btrfs: __btrfs_buffered_write: Reserve/release extents aligned to block size Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 02/12] Btrfs: Compute and look up csums based on sectorsized blocks Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 03/12] Btrfs: Direct I/O read: Work " Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 04/12] Btrfs: fallocate: Work with " Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 05/12] Btrfs: btrfs_page_mkwrite: Reserve space in sectorsized units Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 06/12] Btrfs: Search for all ordered extents that could span across a page Chandan Rajendra
2016-01-21 10:25 ` [PATCH V10 07/12] Btrfs: Use (eb->start, seq) as search key for tree modification log Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 08/12] Btrfs: btrfs_submit_direct_hook: Handle map_length < bio vector length Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 09/12] Btrfs: Limit inline extents to root->sectorsize Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 10/12] Btrfs: Fix block size returned to user space Chandan Rajendra
2016-01-21 10:26 ` [PATCH V10 11/12] Btrfs: Clean pte corresponding to page straddling i_size Chandan Rajendra
2016-01-21 10:26 ` Chandan Rajendra [this message]
2016-01-29 13:30 ` [PATCH V10 00/12] Btrfs: Pre subpagesize-blocksize cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453371964-4917-13-git-send-email-chandan@linux.vnet.ibm.com \
--to=chandan@linux.vnet.ibm.com \
--cc=bo.li.liu@oracle.com \
--cc=chandan@mykolab.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).