From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Cc: clm@fb.com, Filipe Manana <fdmanana@suse.com>
Subject: [PATCH] Btrfs extent_same (dedup) ioctl fixes
Date: Mon, 1 Feb 2016 13:48:23 +0000 [thread overview]
Message-ID: <1454334503-7715-1-git-send-email-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
Hi Chris,
Please consider the following fixes for the extent_same ioctl. They fix
issues related to missing proper page and range locking, which lead to
invalid memory accesses and other unexpected failures (such as data
checksum validation failures, on perfectly healthy hardware, making
the ioctl fail with a non sense -ENOMEM error).
The last patch just removes a function not needed anymore after the two
fixes. I've tagged the two fixes for stable releases.
These were all previously sent to the mailing list.
Thanks.
The following changes since commit e410e34fad913dd568ec28d2a9949694324c14db:
Revert "btrfs: synchronize incompat feature bits with sysfs files" (2016-01-29 08:19:37 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.git extent_same_fixes
for you to fetch changes up to 30b809be1e150f91c5bbaf74d6a23bc81b37e2d9:
Btrfs: remove no longer used function extent_read_full_page_nolock() (2016-01-30 17:54:25 +0000)
----------------------------------------------------------------
Filipe Manana (3):
Btrfs: fix invalid page accesses in extent_same (dedup) ioctl
Btrfs: fix page reading in extent_same ioctl leading to csum errors
Btrfs: remove no longer used function extent_read_full_page_nolock()
fs/btrfs/compression.c | 6 +-----
fs/btrfs/extent_io.c | 45 +++++++++++----------------------------------
fs/btrfs/extent_io.h | 3 ---
fs/btrfs/ioctl.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------
4 files changed, 109 insertions(+), 64 deletions(-)
--
2.7.0.rc3
reply other threads:[~2016-02-01 13:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454334503-7715-1-git-send-email-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=clm@fb.com \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).