* [PATCH 1/3] btrfs: backref: String formatting fixes
@ 2016-02-21 1:31 Simon Quigley
2016-02-21 1:31 ` [PATCH 2/3] btrfs: backref: Fixed string formatting error Simon Quigley
2016-02-21 1:31 ` [PATCH 3/3] btrfs: backref: Fixed string error generated by Checkpatch Simon Quigley
0 siblings, 2 replies; 3+ messages in thread
From: Simon Quigley @ 2016-02-21 1:31 UTC (permalink / raw)
To: clm; +Cc: linux-btrfs, linux-kernel, Simon Quigley
Checkpatch warns about a multi-line string
This fixes that issue and seperates the variables to another line
Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
fs/btrfs/backref.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 956fffa..a2c0595 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1795,9 +1795,9 @@ static int iterate_inode_refs(u64 inum, struct btrfs_root *fs_root,
for (cur = 0; cur < btrfs_item_size(eb, item); cur += len) {
name_len = btrfs_inode_ref_name_len(eb, iref);
/* path must be released before calling iterate()! */
- pr_debug("following ref at offset %u for inode %llu in "
- "tree %llu\n", cur, found_key.objectid,
- fs_root->objectid);
+ pr_debug("following ref at offset %u for inode %llu in tree %llu\n",
+ cur, found_key.objectid,
+ fs_root->objectid);
ret = iterate(parent, name_len,
(unsigned long)(iref + 1), eb, ctx);
if (ret)
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] btrfs: backref: Fixed string formatting error
2016-02-21 1:31 [PATCH 1/3] btrfs: backref: String formatting fixes Simon Quigley
@ 2016-02-21 1:31 ` Simon Quigley
2016-02-21 1:31 ` [PATCH 3/3] btrfs: backref: Fixed string error generated by Checkpatch Simon Quigley
1 sibling, 0 replies; 3+ messages in thread
From: Simon Quigley @ 2016-02-21 1:31 UTC (permalink / raw)
To: clm; +Cc: linux-btrfs, linux-kernel, Simon Quigley
Checkpatch reported an error that there was a multi-line string.
This puts the string on one line and the variables on another.
Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
fs/btrfs/backref.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index a2c0595..632845a 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1696,9 +1696,8 @@ int iterate_extent_inodes(struct btrfs_fs_info *fs_info,
break;
ULIST_ITER_INIT(&root_uiter);
while (!ret && (root_node = ulist_next(roots, &root_uiter))) {
- pr_debug("root %llu references leaf %llu, data list "
- "%#llx\n", root_node->val, ref_node->val,
- ref_node->aux);
+ pr_debug("root %llu references leaf %llu, data list %#llx\n",
+ root_node->val, ref_node->val, ref_node->aux);
ret = iterate_leaf_refs((struct extent_inode_elem *)
(uintptr_t)ref_node->aux,
root_node->val,
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] btrfs: backref: Fixed string error generated by Checkpatch
2016-02-21 1:31 [PATCH 1/3] btrfs: backref: String formatting fixes Simon Quigley
2016-02-21 1:31 ` [PATCH 2/3] btrfs: backref: Fixed string formatting error Simon Quigley
@ 2016-02-21 1:31 ` Simon Quigley
1 sibling, 0 replies; 3+ messages in thread
From: Simon Quigley @ 2016-02-21 1:31 UTC (permalink / raw)
To: clm; +Cc: linux-btrfs, linux-kernel, Simon Quigley
Checkpatch threw an error that this string was on two lines.
I put the string on one line and the variables on the other
Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
fs/btrfs/backref.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 632845a..6e694f7 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1636,9 +1636,8 @@ static int iterate_leaf_refs(struct extent_inode_elem *inode_list,
int ret = 0;
for (eie = inode_list; eie; eie = eie->next) {
- pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), "
- "root %llu\n", extent_item_objectid,
- eie->inum, eie->offset, root);
+ pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), root %llu\n",
+ extent_item_objectid, eie->inum, eie->offset, root);
ret = iterate(eie->inum, eie->offset, root, ctx);
if (ret) {
pr_debug("stopping iteration for %llu due to ret=%d\n",
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-21 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-21 1:31 [PATCH 1/3] btrfs: backref: String formatting fixes Simon Quigley
2016-02-21 1:31 ` [PATCH 2/3] btrfs: backref: Fixed string formatting error Simon Quigley
2016-02-21 1:31 ` [PATCH 3/3] btrfs: backref: Fixed string error generated by Checkpatch Simon Quigley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).