linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
	Eryu Guan <eguan@redhat.com>
Subject: [PATCH v2] fstest: btrfs: test single 4k extent after subpagesize buffered writes
Date: Thu, 17 Mar 2016 15:56:38 -0700	[thread overview]
Message-ID: <1458255398-26833-1-git-send-email-bo.li.liu@oracle.com> (raw)
In-Reply-To: <1457396879-30572-1-git-send-email-bo.li.liu@oracle.com>

This is to test if COW enabled btrfs can end up with single 4k extents
when doing subpagesize buffered writes.

The patch to fix the problem is
  https://patchwork.kernel.org/patch/8527991/

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
v2: - Teach awk to know system's pagesize.
    - Add "Silence is golden" to output.
    - Use local variables to lower case.
    - Add comments to make code clear.

 tests/btrfs/027     | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/027.out |   2 ++
 tests/btrfs/group   |   1 +
 3 files changed, 105 insertions(+)
 create mode 100755 tests/btrfs/027
 create mode 100644 tests/btrfs/027.out

diff --git a/tests/btrfs/027 b/tests/btrfs/027
new file mode 100755
index 0000000..19d324b
--- /dev/null
+++ b/tests/btrfs/027
@@ -0,0 +1,102 @@
+#! /bin/bash
+# FS QA Test 027
+#
+# When btrfs is using cow mode, buffered writes of sub-pagesize can end up with
+# single 4k extents.
+# Ref:
+#     "Stray 4k extents with slow buffered writes"
+#     https://www.spinics.net/lists/linux-btrfs/msg52628.html
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2016 Liu Bo.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+
+	# restore expire
+	echo $default_expire > /proc/sys/vm/dirty_expire_centisecs
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+echo "Silence is golden"
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+_require_xfs_io_command "fiemap"
+
+_scratch_mkfs >> $seqres.full 2>&1
+_scratch_mount
+
+default_expire=`cat /proc/sys/vm/dirty_expire_centisecs`
+# Make it flush dirty pages more frequently to make sure we reproduce the bug.
+echo 50 > /proc/sys/vm/dirty_expire_centisecs
+
+tfile=$SCRATCH_MNT/testfile
+pagesize=$(get_page_size)
+sublen=$((RANDOM % pagesize))
+
+$XFS_IO_PROG -f -c "pwrite 0 $pagesize" $tfile > /dev/null 2>&1
+# write some subpagesize data first.
+$XFS_IO_PROG -c "pwrite $pagesize $sublen" $tfile > /dev/null 2>&1
+
+# Mix up "abnormal" subpagesize writes with normal pagesize based writes
+toff=$((pagesize + sublen))
+for ((i = 0; i < 10000; i++))
+do
+	tlen=$pagesize
+	if [ $((i % 2)) = 0 ]; then
+		tlen=$((pagesize * 3))
+	fi
+	if [ $((i % 1000)) = 0 ]; then
+		tlen=$((RANDOM % pagesize))
+	fi
+
+	$XFS_IO_PROG -c "pwrite $toff $tlen" $tfile > /dev/null 2>&1
+	toff=$((toff + tlen))
+done
+
+sync
+
+# check for single PAGESIZE extent
+$XFS_IO_PROG -c "fiemap -v" $tfile >> $seqres.full 2>&1
+$XFS_IO_PROG -c "fiemap -v" $tfile | \
+awk -v pgsize=$pagesize '{n = pgsize/512; if ($4 == n) print $4}'
+
+# success, all done
+status=0
+exit
diff --git a/tests/btrfs/027.out b/tests/btrfs/027.out
new file mode 100644
index 0000000..ef78cda
--- /dev/null
+++ b/tests/btrfs/027.out
@@ -0,0 +1,2 @@
+QA output created by 027
+Silence is golden
diff --git a/tests/btrfs/group b/tests/btrfs/group
index a2fa412..f06d5fe 100644
--- a/tests/btrfs/group
+++ b/tests/btrfs/group
@@ -29,6 +29,7 @@
 024 auto quick compress
 025 auto quick send clone
 026 auto quick compress prealloc
+027 auto
 029 auto quick clone
 030 auto quick send
 031 auto quick subvol clone
-- 
2.5.0


  parent reply	other threads:[~2016-03-17 22:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 23:47 [PATCH] fstest: btrfs: test single 4k extent after subpagesize buffered writes Liu Bo
2016-03-08  0:27 ` [PATCH v2] " Liu Bo
2016-03-15  3:39   ` Dave Chinner
2016-03-17  4:13     ` Liu Bo
2016-03-17  4:24       ` Eryu Guan
2016-03-17 22:23         ` Liu Bo
2016-03-17 21:07       ` Dave Chinner
2016-03-17 21:31         ` Liu Bo
2016-03-17 22:56   ` Liu Bo [this message]
2016-03-22  4:00     ` Eryu Guan
2016-03-22 22:12       ` Liu Bo
2016-03-23 11:53         ` Eryu Guan
2016-03-24  4:52           ` Liu Bo
2016-03-29  2:13             ` Liu Bo
2016-03-24  4:55     ` [PATCH v3] " Liu Bo
2016-03-24  8:31       ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458255398-26833-1-git-send-email-bo.li.liu@oracle.com \
    --to=bo.li.liu@oracle.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).