linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: linux-btrfs@vger.kernel.org, dsterba@suse.cz, jbacik@fb.com
Cc: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Subject: [RFC PATCH v2.1 10/16] btrfs-progs: fsck: Introduce function to check dev used space
Date: Tue, 17 May 2016 17:38:44 +0800	[thread overview]
Message-ID: <1463477930-3925-11-git-send-email-quwenruo@cn.fujitsu.com> (raw)
In-Reply-To: <1463477930-3925-1-git-send-email-quwenruo@cn.fujitsu.com>

From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

Introduce function check_dev_item() to check used space with dev extent
items.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 cmds-check.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/cmds-check.c b/cmds-check.c
index 79a22c9..eec9648 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -327,6 +327,7 @@ struct root_item_info {
 #define CROSSING_STRIPE_BOUNDARY (1 << 4) /* For kernel scrub workaround */
 #define ITEM_SIZE_MISMATCH	(1 << 5) /* Bad item size */
 #define UNKNOWN_TYPE		(1 << 6) /* Unknown type */
+#define ACCOUNTING_MISMATCH	(1 << 7) /* Used space accounting error */
 
 static void *print_status_check(void *p)
 {
@@ -9251,6 +9252,69 @@ out:
 	return 0;
 }
 
+/*
+ * Check the used space is correct with the dev item
+ */
+static int check_dev_item(struct btrfs_fs_info *fs_info,
+			  struct extent_buffer *eb, int slot)
+{
+	struct btrfs_root *dev_root = fs_info->dev_root;
+	struct btrfs_dev_item *dev_item;
+	struct btrfs_path path;
+	struct btrfs_key key;
+	struct btrfs_dev_extent *ptr;
+	u64 dev_id;
+	u64 used;
+	u64 total = 0;
+	int ret;
+
+	dev_item = btrfs_item_ptr(eb, slot, struct btrfs_dev_item);
+	dev_id = btrfs_device_id(eb, dev_item);
+	used = btrfs_device_bytes_used(eb, dev_item);
+
+	key.objectid = dev_id;
+	key.type = BTRFS_DEV_EXTENT_KEY;
+	key.offset = 0;
+
+	btrfs_init_path(&path);
+	ret = btrfs_search_slot(NULL, dev_root, &key, &path, 0, 0);
+	if (ret < 0) {
+		btrfs_item_key_to_cpu(eb, &key, slot);
+		error("Couldn't find any releative dev extent for dev[%llu, %u, %llu]",
+		      key.objectid, key.type, key.offset);
+		btrfs_release_path(&path);
+		return REFERENCER_MISSING;
+	}
+
+	/* Iterate dev_extents to calculate the used space of a device */
+	while (1) {
+		btrfs_item_key_to_cpu(path.nodes[0], &key, path.slots[0]);
+
+		if (key.objectid > dev_id)
+			break;
+		if (key.type != BTRFS_DEV_EXTENT_KEY || key.objectid != dev_id)
+			goto next;
+
+		ptr = btrfs_item_ptr(path.nodes[0], path.slots[0],
+				     struct btrfs_dev_extent);
+		total += btrfs_dev_extent_length(path.nodes[0], ptr);
+next:
+		ret = btrfs_next_item(dev_root, &path);
+		if (ret)
+			break;
+	}
+	btrfs_release_path(&path);
+
+	if (used != total) {
+		btrfs_item_key_to_cpu(eb, &key, slot);
+		error("Dev extent's total-byte(%llu) is not equal to byte-used(%llu) in dev[%llu, %u, %llu]",
+		      total, used, BTRFS_ROOT_TREE_OBJECTID,
+		      BTRFS_DEV_EXTENT_KEY, dev_id);
+		return ACCOUNTING_MISMATCH;
+	}
+	return 0;
+}
+
 static int btrfs_fsck_reinit_root(struct btrfs_trans_handle *trans,
 			   struct btrfs_root *root, int overwrite)
 {
-- 
2.8.2




  parent reply	other threads:[~2016-05-17  9:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  9:38 [RFC PATCH v2.1 00/16] Introduce low memory usage btrfsck mode Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 01/16] btrfs-progs: fsck: Introduce function to check tree block backref in extent tree Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 02/16] btrfs-progs: fsck: Introduce function to check data " Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 03/16] btrfs-progs: fsck: Introduce function to query tree block level Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 04/16] btrfs-progs: fsck: Introduce function to check referencer of a backref Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 05/16] btrfs-progs: fsck: Introduce function to check shared block ref Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 06/16] btrfs-progs: fsck: Introduce function to check referencer for data backref Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 07/16] btrfs-progs: fsck: Introduce function to check shared " Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 08/16] btrfs-progs: fsck: Introduce function to check an extent Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 09/16] btrfs-progs: fsck: Introduce function to check dev extent item Qu Wenruo
2016-05-17  9:38 ` Qu Wenruo [this message]
2016-05-17  9:38 ` [RFC PATCH v2.1 11/16] btrfs-progs: fsck: Introduce function to check block group item Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 12/16] btrfs-progs: fsck: Introduce function to check chunk item Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 13/16] btrfs-progs: fsck: Introduce hub function for later fsck Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 14/16] btrfs-progs: fsck: Introduce function to speed up fs tree check Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 15/16] btrfs-progs: fsck: Introduce traversal function for fsck Qu Wenruo
2016-05-17  9:38 ` [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode Qu Wenruo
2016-05-17 15:29   ` Josef Bacik
2016-05-18  0:58     ` Qu Wenruo
2016-05-19 14:51       ` David Sterba
2016-05-20  2:33         ` Qu Wenruo
2016-05-23 11:08           ` David Sterba
2016-05-24  3:19             ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463477930-3925-11-git-send-email-quwenruo@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lufq.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).