From: Anand Jain <anand.jain@oracle.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 2/6] fstests: btrfs: add functions to get and put a device for replace target
Date: Wed, 15 Jun 2016 16:47:02 +0800 [thread overview]
Message-ID: <1465980422-18947-1-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1463495530-425-2-git-send-email-anand.jain@oracle.com>
From: Anand Jain <Anand.Jain@oracle.com>
For the replace tests we need a device as a spare device,
here functions _spare_dev_get() and _spare_dev_put()
will get it from the SCRATCH_DEV_POOL_SAVED, which is set
when _scratch_dev_pool_get() is called, and is based on how
many has already been assigned to SCRATCH_DEV_POOL.
usage:
_scratch_dev_pool_get 3
_spare_dev_get
SPARE_DEV will have a device set which can be
used as the replace target device.
_spare_dev_put
_scratch_dev_pool_put
_spare_dev_get() will pick the next device after SCRATCH_DEV_POOL
devices, from the SCRATCH_DEV_POOL_SAVED, and assigns it to
SPARE_DEV. _spare_dev_put() will set to SPARE_DEV to null.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v2: Added comments
common/rc | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/common/rc b/common/rc
index 31c46ba1226e..ffdbfcdae68d 100644
--- a/common/rc
+++ b/common/rc
@@ -802,6 +802,65 @@ _scratch_mkfs()
esac
}
+# Helper function to get a spare or replace-target device from
+# configured SCRATCH_DEV_POLL, must call _scratch_dev_pool_get()
+# before _spare_dev_get(). Replace-target-device/Spare-device will
+# be assigned to SPARE_DEV.
+# As of now only one replace-target-device/spare-device can be
+# assigned.
+#
+# Usage:
+# _scratch_dev_pool_get() <ndevs>
+# _spare_dev_get()
+# :: do stuff
+# _spare_dev_put()
+# _scratch_dev_pool_put()
+#
+_spare_dev_get()
+{
+ typeset -p SCRATCH_DEV_POOL_SAVED >/dev/null 2>&1
+ if [ $? != 0 ]; then
+ _fail "Bug: unset val, must call _scratch_dev_pool_get before _spare_dev_get"
+ fi
+
+ if [ -z "$SCRATCH_DEV_POOL_SAVED" ]; then
+ _fail "Bug: str empty, must call _scratch_dev_pool_get before _spare_dev_get"
+ fi
+
+ # Check if the spare is already assigned
+ typeset -p SPARE_DEV >/dev/null 2>&1
+ if [ $? == 0 ]; then
+ if [ ! -z "$SPARE_DEV" ]; then
+ _fail "Bug: SPARE_DEV = $SPARE_DEV already assigned"
+ fi
+ fi
+
+ local ndevs=`echo $SCRATCH_DEV_POOL| wc -w`
+ local config_ndevs=`echo $SCRATCH_DEV_POOL_SAVED| wc -w`
+
+ if [ $ndevs -eq $config_ndevs ]; then
+ _notrun "All devs used no spare"
+ fi
+ # Get a dev that is not used
+ local devs[]="( $SCRATCH_DEV_POOL_SAVED )"
+ SPARE_DEV=${devs[@]:$ndevs:1}
+ export SPARE_DEV
+}
+
+_spare_dev_put()
+{
+ typeset -p SPARE_DEV >/dev/null 2>&1
+ if [ $? != 0 ]; then
+ _fail "Bug: unset val, must call _spare_dev_get before its put"
+ fi
+
+ if [ -z "$SPARE_DEV" ]; then
+ _fail "Bug: str empty, must call _spare_dev_get before its put"
+ fi
+
+ export SPARE_DEV=""
+}
+
#
# Generally test cases will have..
# _require_scratch_dev_pool X
--
2.7.0
next prev parent reply other threads:[~2016-06-15 8:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:32 [PATCH 1/6] fstests: btrfs: add functions to set and reset required number of SCRATCH_DEV_POOL Anand Jain
2016-05-17 14:32 ` [PATCH 2/6] fstests: btrfs: add functions to get and put a device for replace target Anand Jain
2016-06-12 4:42 ` Eryu Guan
2016-06-15 8:45 ` Anand Jain
2016-06-15 8:47 ` Anand Jain [this message]
2016-05-17 14:32 ` [PATCH 3/6] fstests: btrfs: 027 make use of new device get and put helper functions Anand Jain
2016-05-17 14:32 ` [PATCH 4/6] fstests: btrfs: add helper function to check if btrfs is module Anand Jain
2016-06-12 4:53 ` Eryu Guan
2016-06-15 8:45 ` Anand Jain
2016-06-15 8:47 ` [PATCH v2 " Anand Jain
2016-05-17 14:32 ` [PATCH 5/6] fstests: btrfs: test RAID1 device reappear and balanced Anand Jain
2016-06-12 5:06 ` Eryu Guan
2016-06-15 8:45 ` Anand Jain
2016-06-15 8:48 ` [PATCH v2 " Anand Jain
2016-06-21 13:31 ` Eryu Guan
2016-06-22 11:01 ` Anand Jain
2016-06-27 9:29 ` Eryu Guan
2016-06-30 11:04 ` Anand Jain
2016-06-30 14:58 ` Eryu Guan
2016-06-23 13:28 ` [PATCH v3 2/6] fstests: btrfs: add functions to get and put a device for replace target Anand Jain
2016-06-30 10:58 ` [PATCH v3 5/6] fstests: btrfs: test RAID1 device reappear and balanced Anand Jain
2016-05-17 14:32 ` [PATCH 6/6] fstests: btrfs: test RAID5 device reappear and balance Anand Jain
2016-06-12 5:08 ` Eryu Guan
2016-06-15 8:51 ` Anand Jain
2016-06-15 8:49 ` [PATCH v2 " Anand Jain
2016-06-30 10:59 ` [PATCH v3 " Anand Jain
2016-06-12 4:40 ` [PATCH 1/6] fstests: btrfs: add functions to set and reset required number of SCRATCH_DEV_POOL Eryu Guan
2016-06-15 8:44 ` Anand Jain
2016-06-15 8:46 ` [PATCH v2 " Anand Jain
2016-06-21 13:20 ` Eryu Guan
2016-06-22 11:01 ` Anand Jain
2016-06-23 13:25 ` [PATCH v3 " Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465980422-18947-1-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).